Repository navigation
Preserve embedded comment characters in parsed INI values - #85
Closed
jovial-liu wants to merge 1 commit into
Closed
jovial-liu wants to merge 1 commit into
jovial-liu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IniConfig.parse()currently truncateshttps://example.com/#fragmenttohttps://example.com/anda;btoawhen stripping inline comments. This also affects continuation lines.Treat
#and;as comment prefixes only at the start of a value or after whitespace, matchingconfigparserwith inline comment prefixes enabled. Preserve embedded delimiters, including when a later whitespace-delimited comment is present. Document the rule and update the existing no-whitespace test to reflect it.This addresses bug 2 in #83. The malformed-section-header proposal and broader compatibility policy can be considered separately. The constructor and
strip_inline_comments=Falseretain their existing behavior.Validation on Python 3.12:
Prepared with OpenAI Codex.