Repository navigation
Conversation
On a server that makes calendars but will not delete them (Synology), every run left new ones behind for good: a fresh testcalendar-<uuid> from the create/delete probe, and a new csc_duplicate_uid_cal2 and csc_move_cal2, made by name and so at a new cal_id each time. One test account held over 200 of them. The create/delete probe now takes the calendar an earlier run left at its fixed cal_id as the evidence that creation works, and the two second calendars get fixed cal_ids and are emptied and used again. After the first run the creation delay goes untimed there, and a server taking MKCOL only still gets a new calendar each run. Prompts: > We should create reusable calendars for servers where it's not > possible to delete the calendar. > start the tests for jeanes. Check the reuse statis (sic) in > [caldav and caldav-server-tester] > Fix in the tester. Check that there are no PRs or branches already > fixing this first. Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Two findings of the review of the change above, filed rather than fixed: on a server that cannot delete calendars, later runs overrule a first run's create-calendar grade with "full", and the probes at fixed cal_ids come out unknown. Prompt: [file issues found during the review process] Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and text generated by Claude Opus 5.5 (Claude Code); prompts are in the commit message below.
Commit message:
fix: leave no new calendars where none can go
On a server that makes calendars but will not delete them (Synology),
every run left new ones behind for good: a fresh testcalendar-
from the create/delete probe, and a new csc_duplicate_uid_cal2 and
csc_move_cal2, made by name and so at a new cal_id each time. One
test account held over 200 of them. The create/delete probe now takes
the calendar an earlier run left at its fixed cal_id as the evidence
that creation works, and the two second calendars get fixed cal_ids
and are emptied and used again. After the first run the creation
delay goes untimed there, and a server taking MKCOL only still gets a
new calendar each run.
Prompts:
Assisted-By: Claude Opus 5.5
Also piggy-backing:
docs: note what re-runs lose on Synology(two review findings filed in docs/TODO.md rather than fixed).🤖 Generated with Claude Code