Repository navigation
feat(search): negated and def property filters - #750
Merged
Merged
Conversation
icalendar-searcher gains !=, !contains and def. The XML builder sent a positive text-match for != (the opposite result set) and raised KeyError for def. A negated text-match is a negated substring match, so only !contains maps onto it; != and def become a bare prop-filter. search() leaves all three out of the server query and filters client-side (unless post_filter=False), until caldav-server-tester probes negate-condition. The icalendar-searcher floor goes to 1.1.0. Ref: #568 Prompt: we may need a "does not contain"-operator, and the caldav side needs to be fixed. Followup-Prompt: Add the icalendar-searcher floor in the caldav pyproject.toml file, even if it's not released yet. That would cause the PR to fail quickly, rather than after running tests for half an hour, and it would avoid having to push another commit later. Followup-Prompt: and force-push that as an amend [= the floor bump] Followup-Prompt: #750 has to be rebased, and now the icalendar-searcher floor should be set to 1.1 [#750; 1.1.0 is now on PyPI] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
search() decides the negated-search operators client-side. Record the caldav-server-tester probe for negate-condition, after which servers that honour it could be sent !contains, in the TODO list. Ref: #568 Prompt: [fix issues found during the review process] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
negated-search
branch
from
October 12, 2026 12:56
bdf2161 to
8d7c6c0
Compare
tobixen
added a commit
that referenced
this pull request
Nov 18, 2026
Negated searches (2.1) landed in v3.5.0 apart from server detection and functional tests; conflicts raise UidConflictError naming the holder (4.1); non-GET redirects, PROPFIND included, are followed on the same origin with a loop limit (4.3). Closed issues 71, 94, 612 and 680 are ticked. #750 #833 #837 Prompt: Please check all the checkboxes that should be checked [in the NLnet-funded roadmaps, while drafting payment requests] Assisted-By: Claude Opus 5.5 (Claude Code) Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caldav's share of #568 (negated searches). Needs the
!=/<>,!containsanddefoperators from icalendar-searcher (branchnegation-operators, to be released as 1.1.0). The floor is raised to>=1.1.0, so CI fails until that release is out.Code and this text are AI-generated (Claude Opus 5.5); the commit messages carry the prompts.