Repository navigation
feat: version-stamp the Zimbra profile - #839
Merged
Merged
Conversation
The zimbra profile was measured against the 2017 zcs-foss docker image (8.8). A Zimbra 10.1.21 server answers a PUT of a taken UID with 412 and the precondition rather than 403/409, so it failed testCheckCompatibility. No Zimbra 10 docker image exists, so the profile is split like bedework's; the old name still resolves, to zimbra_8_8. Named in a config it gives a FutureWarning, as DeprecationWarning is hidden by Python's default filters; accessed as compatibility_hints.zimbra in code it gives a DeprecationWarning. For the same reason the deprecated config keys testing_allowed and priority now give a FutureWarning instead of a DeprecationWarning. Prompt: work zimbra is Zimbra 10.1.21_GA_4899 (build 20260916050914) - it's quite normal for zimbra to add regressions in their caldav support in their "upgrades". Can we get the zimbra docker container updated? If not, then we should have versioned profiles like with bedework Followup-Prompt: go for the small fix. [rename zimbra to zimbra_8_8 with a deprecated alias, add zimbra_10_1] Prompts (comments made inline in the document while reviewing it): > (on whether to split the config-key warning change into its own commit) don't bother the split, make the message clear Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
feat/zimbra-versioned-profiles
branch
from
October 29, 2026 14:56
9af8578 to
db4491b
Compare
tobixen
added a commit
to python-caldav/caldav-server-tester
that referenced
this pull request
Oct 30, 2026
caldav renames its zimbra compatibility profile zimbra_8_8 and adds zimbra_10_1 (python-caldav/caldav#839). The --caldav-features help text, a docstring and the example in USAGE.md still named the old one; the TODO on following the rename goes. Prompt: if (sic) the caldav-server-tester help text in master, without pushing [fix the help text and docstring that still name caldav's old `zimbra` profile] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Correction to the commit message: after review, a config naming
zimbragets a FutureWarning, not a DeprecationWarning (which Python hides by default when raised insidecaldav.config);compatibility_hints.zimbrain code gets the DeprecationWarning. The deprecated test keystesting_allowedandprioritywere switched to FutureWarning as well, for the same reason - seechanges/+config-deprecations-visible.changed.md.