Skip to content

feat: version-stamp the Zimbra profile - #839

Merged
tobixen merged 1 commit into
masterfrom
feat/zimbra-versioned-profiles
Oct 29, 2026
Merged

tobixen merged 1 commit into
masterfrom
feat/zimbra-versioned-profiles

Conversation

@tobixen

@tobixen tobixen commented Oct 29, 2026

Copy link
Copy Markdown
Member

Commit message:

feat: version-stamp the Zimbra profile

The zimbra profile was measured against the 2017 zcs-foss docker
image (8.8).  A Zimbra 10.1.21 server answers a PUT of a taken UID
with 412 and the precondition rather than 403/409, so it failed
testCheckCompatibility.  No Zimbra 10 docker image exists, so the
profile is split like bedework's; the old name still resolves, to
zimbra_8_8, with a DeprecationWarning.

Prompt: work zimbra is Zimbra 10.1.21_GA_4899 (build 20260916050914) - it's quite normal for zimbra to add regressions in their caldav support in their "upgrades".  Can we get the zimbra docker container updated?  If not, then we should have versioned profiles like with bedework
Followup-Prompt: go for the small fix. [rename zimbra to zimbra_8_8 with a deprecated alias, add zimbra_10_1]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

Correction to the commit message: after review, a config naming zimbra gets a FutureWarning, not a DeprecationWarning (which Python hides by default when raised inside caldav.config); compatibility_hints.zimbra in code gets the DeprecationWarning. The deprecated test keys testing_allowed and priority were switched to FutureWarning as well, for the same reason - see changes/+config-deprecations-visible.changed.md.

Comment thread tests/test_compatibility_hints.py Fixed
Comment thread tests/test_compatibility_hints.py Fixed
Comment thread tests/test_compatibility_hints.py Fixed
Comment thread tests/test_compatibility_hints.py Fixed
The zimbra profile was measured against the 2017 zcs-foss docker
image (8.8).  A Zimbra 10.1.21 server answers a PUT of a taken UID
with 412 and the precondition rather than 403/409, so it failed
testCheckCompatibility.  No Zimbra 10 docker image exists, so the
profile is split like bedework's; the old name still resolves, to
zimbra_8_8.  Named in a config it gives a FutureWarning, as
DeprecationWarning is hidden by Python's default filters; accessed as
compatibility_hints.zimbra in code it gives a DeprecationWarning.

For the same reason the deprecated config keys testing_allowed and
priority now give a FutureWarning instead of a DeprecationWarning.

Prompt: work zimbra is Zimbra 10.1.21_GA_4899 (build 20260916050914) - it's quite normal for zimbra to add regressions in their caldav support in their "upgrades".  Can we get the zimbra docker container updated?  If not, then we should have versioned profiles like with bedework
Followup-Prompt: go for the small fix. [rename zimbra to zimbra_8_8 with a deprecated alias, add zimbra_10_1]
Prompts (comments made inline in the document while reviewing it):
> (on whether to split the config-key warning change into its own commit) don't bother the split, make the message clear

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
@tobixen
tobixen force-pushed the feat/zimbra-versioned-profiles branch from 9af8578 to db4491b Compare October 29, 2026 14:56
@tobixen
tobixen merged commit db4491b into master Oct 29, 2026
19 checks passed
@tobixen
tobixen deleted the feat/zimbra-versioned-profiles branch October 29, 2026 19:21
tobixen added a commit to python-caldav/caldav-server-tester that referenced this pull request Oct 30, 2026
caldav renames its zimbra compatibility profile zimbra_8_8 and adds
zimbra_10_1 (python-caldav/caldav#839).  The
--caldav-features help text, a docstring and the example in USAGE.md
still named the old one; the TODO on following the rename goes.

Prompt: if (sic) the caldav-server-tester help text in master, without pushing [fix the help text and docstring that still name caldav's old `zimbra` profile]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant