Skip to content

fix: report failed properties in PROPPATCH multistatus responses - #859

Merged
tobixen merged 1 commit into
python-caldav:masterfrom
shrohan2003:fix/proppatch-status
Nov 15, 2026
Merged

tobixen merged 1 commit into
python-caldav:masterfrom
shrohan2003:fix/proppatch-status

Conversation

@shrohan2003

Copy link
Copy Markdown
Contributor

Fixes #792. An HTTP 207 response to a PROPPATCH can contain a failure even when another property reports success. Both the sync and async set_properties entry points previously returned the calendar for a response containing a 403.

Use the existing DAVResponse.all_statuses_ok() check in the shared post-processing step. The regression exercises both public entry points, checking a mixed 200/403 response and an all-200 response. Both mixed-status tests failed on the base revision.

Codex (GPT-6) reproduced the reported behavior, prepared the patch and ran the tests. On Python 3.12 the CalDAV unit and async-client suites passed (925 passed, 2 skipped). The server responses are synthetic.

Codex reproduced issue python-caldav#792, implemented the fix and regression tests, and ran: python -m pytest -q tests/test_caldav_unit.py tests/test_async_davclient.py

Assisted-By: OpenAI Codex (GPT-6)
@tobixen
tobixen merged commit 7809008 into python-caldav:master Nov 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set_properties() silently ignores per-property PROPPATCH failures (regression since v3.0)

2 participants