Repository navigation
fix: report failed properties in PROPPATCH multistatus responses - #859
Merged
Merged
Conversation
Codex reproduced issue python-caldav#792, implemented the fix and regression tests, and ran: python -m pytest -q tests/test_caldav_unit.py tests/test_async_davclient.py Assisted-By: OpenAI Codex (GPT-6)
shrohan2003
force-pushed
the
fix/proppatch-status
branch
from
November 13, 2026 19:15
ff972a5 to
67991e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #792. An HTTP 207 response to a PROPPATCH can contain a failure even when another property reports success. Both the sync and async set_properties entry points previously returned the calendar for a response containing a 403.
Use the existing DAVResponse.all_statuses_ok() check in the shared post-processing step. The regression exercises both public entry points, checking a mixed 200/403 response and an all-200 response. Both mixed-status tests failed on the base revision.
Codex (GPT-6) reproduced the reported behavior, prepared the patch and ran the tests. On Python 3.12 the CalDAV unit and async-client suites passed (925 passed, 2 skipped). The server responses are synthetic.