Skip to content

fix: Bedework exceptions, load(fallbacks=False), keep server expansion - #868

Merged
tobixen merged 3 commits into
masterfrom
fix/search-drops-exceptions
Nov 14, 2026
Merged

tobixen merged 3 commits into
masterfrom
fix/search-drops-exceptions

Conversation

@tobixen

@tobixen tobixen commented Nov 14, 2026

Copy link
Copy Markdown
Member

Disclaimer: AI-generated code and text below the line, generated by Claude Opus 5.5


Follow-up to #867, which was merged before these three commits reached its branch.

🤖 Generated with Claude Code

caldav-server-tester graded save-load.event.recurrences.exception off a
search, and Bedework's searches leave the exception out.  Probed by a
GET, Bedework 3.10 and 5 keep both in one object, so the hint is full
for both.  On Bedework 5, search() then expands on the client again,
which search.recurrences.exception.in-calendar-data makes work.

Prompt: Please fix the caldav-server-tester probe [ref #867]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
After a 404 for an object with a UID, load() tries a multiget and then
a search by UID, the latter even with multiget_fallback=False.  A
caller comparing a GET with a search, as caldav-server-tester does to
grade search.recurrences.exception.in-calendar-data, then may get a
search for its GET.  With the new fallbacks=False, a failed GET raises.

Prompt: Make a workaround in the caldav libary (sic) ... `def load(..., multiget_fallback=True)` [from the review of the tester probe: load() can fall back to a multiget or a search by UID]
Followup-Prompt: (answer to a clarifying question) An option for "skip every fallback" needs another name, but let's go for it.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Where search.recurrences.exception.in-calendar-data is unsupported,
search() loads the recurring objects it found again.  After a
server-side expansion, each instance carries a RECURRENCE-ID and was
taken for one, and the multiget swapped the occurrences for the
unexpanded master and exception.  search(server_expand=True) without
expand=True then returned the raw objects on Bedework 5.

Prompt: [fix issues found during the review process]

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
@tobixen
tobixen merged commit dbe8619 into master Nov 14, 2026
17 checks passed
@tobixen
tobixen deleted the fix/search-drops-exceptions branch November 17, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant