Repository navigation
fix: Bedework exceptions, load(fallbacks=False), keep server expansion - #868
Merged
Merged
Conversation
caldav-server-tester graded save-load.event.recurrences.exception off a search, and Bedework's searches leave the exception out. Probed by a GET, Bedework 3.10 and 5 keep both in one object, so the hint is full for both. On Bedework 5, search() then expands on the client again, which search.recurrences.exception.in-calendar-data makes work. Prompt: Please fix the caldav-server-tester probe [ref #867] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
After a 404 for an object with a UID, load() tries a multiget and then a search by UID, the latter even with multiget_fallback=False. A caller comparing a GET with a search, as caldav-server-tester does to grade search.recurrences.exception.in-calendar-data, then may get a search for its GET. With the new fallbacks=False, a failed GET raises. Prompt: Make a workaround in the caldav libary (sic) ... `def load(..., multiget_fallback=True)` [from the review of the tester probe: load() can fall back to a multiget or a search by UID] Followup-Prompt: (answer to a clarifying question) An option for "skip every fallback" needs another name, but let's go for it. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Where search.recurrences.exception.in-calendar-data is unsupported, search() loads the recurring objects it found again. After a server-side expansion, each instance carries a RECURRENCE-ID and was taken for one, and the multiget swapped the occurrences for the unexpanded master and exception. search(server_expand=True) without expand=True then returned the raw objects on Bedework 5. Prompt: [fix issues found during the review process] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: AI-generated code and text below the line, generated by Claude Opus 5.5
Follow-up to #867, which was merged before these three commits reached its branch.
save-load.event.recurrences.exceptionis nowfullfor Bedework 3.10 and 5: the object keeps master and exception, it was only the search that left the exception out. On Bedework 5,expand=Truetherefore expands on the client again, which the reload from fix: refetch recurring objects a search cut short #867 makes work.CalendarObjectResource.load(fallbacks=False): the GET alone, with no multiget and no search by UID after a 404. caldav-server-tester needs it to compare a GET with a search (feat: probe whether a search keeps the exceptions caldav-server-tester#61, which re-probed both Bedeworks).search(server_expand=True)withoutexpand=Truereturned the unexpanded master and exception on Bedework 5.🤖 Generated with Claude Code