Repository navigation
fix: Bedework and Zimbra conformance — status line, tz links, task start - #869
Merged
Merged
Conversation
Bedework 5 answers a calendar-multiget naming a missing object with "HTTP/1.1 404": no reason phrase, nor the space before it that RFC 9112 section 4 keeps even when the phrase is empty. The status checks looked for " 404 " with spaces on both sides, so this raised ResponseError where the object should have been reported missing. They now compare the parsed status code, as all_statuses_ok() does. Prompt: ... continue working on getting all the conformance tests passing [in calendaring-client; this fixes calendaring's test_get_missing_raises on Bedework 5] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Zimbra drops a task's DTSTART where the task has no DUE, though RFC 5545 allows either alone; with a DUE it keeps both. The new hint save-load.todo.dtstart-without-due records it, unsupported in the Zimbra 8.8 profile and so in 10.1's (both probed), so a client can tell it will lose the start. Prompt: ... continue working on getting all the conformance tests passing [in calendaring-client] Followup-Prompt: [add] a tester probe and new caldav hint [for the Zimbra behaviour, dropping a task's DTSTART without a DUE] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Bedework 5 refuses an object whose TZID is a tz database link name, such as Europe/Oslo, with 403 "unknownTimezone", VTIMEZONE or not, so a Norwegian user cannot store an event in their own zone there. The new hint save-load.icalendar.tzid-link is ungraceful for it, and save() then sends each link TZID as the zone it points to, from tzdata.zi. Times since 1970 stay where they were; save(raw_data=...) is left alone. Prompt: ... continue working on getting all the conformance tests passing [in calendaring-client] Followup-Prompt: Go with [a caldav-server-tester probe, a caldav hint, and caldav rewriting a tz link name to its canonical zone before saving] for bedework5 Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Code scanning flagged two nits on the tz link change: an `except ModuleNotFoundError: pass` with no explanation, and caldav.lib.vcal imported both with `import` and `from ... import` in the unit tests. Say why the missing tzdata package is fine, and import the module the `from` way like the neighbouring tests. Prompt: Please fix the comment on the empty except on #869 [#869], and fix consistent import style Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Explain the NLnet GenAI policy situation: the project is committed to version 1.1, while version 2.0 only allows read-only use, and the policy will have to be revised if funding continues. Reword the "read this first" rules around contributors adding value, update the disclosure section beyond 3.3.1, and fix a batch of typos. The text is mostly the maintainer's own; the AI did QA and language fixes. Prompt: Can we piggy-back my uncommitted AI-POLICY-change into the same PR? Please do a QA on my changes. [moved to #869 instead of the contributor PR #858] Prompts (comments made inline in the document while reviewing it): Please fix up the findings. https://nlnet.nl/foundation/policies/generativeAI/2.0/ https://nlnet.nl/foundation/policies/generativeAI/1.1/ The project has been receiving funding since before the AI-policy was created, and we're currently committed to the version 1.1 of their AI-policy. Ok [to moving the NLnet paragraph into its own section] We're a bit in a twilight zone, as NLNet wants the 2.0-policy to be adapted. Followup-Prompt: I've amended a bit more (including re-adding that discarding NLnet funding may be considered), do the QA again, and push it into my PR. Do a review-and-merge of #858 also [#858] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Two fixtures carried a real personal mail address, copied from server responses. Replace it with testuser@example.com (and the organizer's with noreply@example.com); the tests do not depend on the value. Prompt: please replace my email address with an @example.com-address Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Follow-up to #858. A component name with trailing whitespace ("BEGIN:VEVENT ") left the raw UID shortcut and made RawDataState.get_uid() return None; strip it. Also cover the rule that an earlier UID line the cheap regex skips (parameters, lowercase) sends the lookup to the full parser. Prompt: [fix issues found during the review process] Followup-Prompt: [merge the contributor's PR as is and do the review fixes in a commit of our own on top] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
UTC, GMT and Zulu are tz database links to Etc/UTC and Etc/GMT; rewriting TZID=UTC gave a TZID on a UTC (Z) time, which RFC 5545 forbids. A VTIMEZONE without a TZID made save() raise KeyError on servers where the link rewrite is active; it is now skipped. Prompt: [fix issues found during the review process] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/status-without-reason
branch
from
November 15, 2026 16:26
2ca70da to
848f2f1
Compare
tobixen
added a commit
to python-caldav/caldav-server-tester
that referenced
this pull request
Nov 16, 2026
#62 Two new probes, matching the hints in python-caldav/caldav#869: save-load.icalendar.tzid-link (Bedework 5 refuses a tz link name as TZID) and save-load.todo.dtstart-without-due (Zimbra drops a task's DTSTART without a DUE). The tester carries the feature definitions until a caldav release has them. Commits: - 15ae655 feat: probe a TZID that is a tz link name - 79c489e feat: probe a task start without a due - 54522b9 test: keep a system pytest-asyncio out of the run Assisted-By: Claude Opus 5.5 Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: AI-generated code and text below the line, generated by Claude Opus 5.5, from the prompts:
Three fixes for server quirks met while getting calendaring-client's conformance tests passing, bundled into one PR since a CI run takes an hour:
HTTP/1.1 404, as Bedework 5 sends in a multiget) is now read by its parsed status code, so a missing object is reported missing, not raised as ResponseError.save-load.icalendar.tzid-link: Bedework 5 refuses a TZID that is a tz database link name (Europe/Oslo) with 403unknownTimezone. Theresave()sends the zone the link points to instead;save(raw_data=...)is left alone.save-load.todo.dtstart-without-due: Zimbra drops a task's DTSTART when the task has no DUE.The commits carry the details. The matching caldav-server-tester probes come in a PR of their own.
🤖 Generated with Claude Code