prevent sensitive header value being logged#289
Open
daddykotex wants to merge 1 commit intopython-hyper:masterfrom
Open
prevent sensitive header value being logged#289daddykotex wants to merge 1 commit intopython-hyper:masterfrom
daddykotex wants to merge 1 commit intopython-hyper:masterfrom
Conversation
Kriechi
reviewed
Mar 14, 2026
src/hpack/hpack.py
Outdated
|
|
||
| When sensitive is True, the header value will be redacted in debug logs | ||
| and logged as "SENSITIVE_REDACTED" to prevent accidental exposure of | ||
| sensitive information. |
Member
There was a problem hiding this comment.
Please mention that this flag has a specific meaning also in the RFC. Currently an unaware user might read this sentence and assume this setting is only for logging - while in fact it has a more specific meaning on the protocol level as well.
Author
There was a problem hiding this comment.
re-written as:
When sensitive is True, the header will not be added to the header table,
furthermore, the header value will be redacted in debug logs, as "SENSITIVE_REDACTED",
to prevent accidental exposure of sensitive information.
Member
|
Would you mind adding a changelog entry and tests to cover the new behaviour? Thanks! |
daddykotex
force-pushed
the
dfrancoeur/sensitive-headers
branch
from
63513fa to
b7a31bc
Compare
daddykotex
force-pushed
the
dfrancoeur/sensitive-headers
branch
from
b7a31bc to
6b99d12
Compare
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #288