gh-145783: Propagate errors raised in NEW_TYPE_COMMENT #145784
gh-145783: Propagate errors raised in NEW_TYPE_COMMENT #145784pablogsal merged 2 commits intopython:mainfrom
NEW_TYPE_COMMENT #145784Conversation
StanFromIreland
requested review from
JelleZijlstra,
lysnikolaou and
pablogsal
as code owners
| _testcapi = import_helper.import_module('_testcapi') | ||
| flags = 0x0800 | 0x1000 # PyCF_IGNORE_COOKIE | PyCF_TYPE_COMMENTS | ||
| with self.assertRaises(UnicodeDecodeError): | ||
| _testcapi.Py_CompileStringExFlags( |
There was a problem hiding this comment.
Why does this need _testcapi? Was the error not reproducible with a direct call to e.g. compile()?
There was a problem hiding this comment.
You can't pass PyCF_IGNORE_COOKIE to compile() (or any other Python API).
>>> compile(b'a=1 # type: \x80', '<test>', 'single', flags=0x0800|0x1000)
ValueError: compile(): unrecognised flags
Since this is the function used in the fuzzer, (I hope) it may be useful for future issues found by it.
|
The fuzzer likes this one so much it just "found" it again 🙃 |
|
Great job @StanFromIreland 👏 |
pablogsal
added
needs backport to 3.13
|
Thanks @StanFromIreland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @StanFromIreland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @StanFromIreland and @pablogsal, I could not cleanly backport this to |
|
Sorry, @StanFromIreland and @pablogsal, I could not cleanly backport this to |
|
@StanFromIreland can you do the backports when you have some time? |
|
GH-145926 is a backport of this pull request to the 3.14 branch. |
…pythonGH-145784) (cherry picked from commit e1c2246) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
…pythonGH-145784) (cherry picked from commit e1c2246) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-145927 is a backport of this pull request to the 3.13 branch. |
3 participants
NEW_TYPE_COMMENT#145783