GH-145914: Fill newly created tuple with Py_None instead of NULL#145913
Open
sergey-miryanov wants to merge 3 commits intopython:mainfrom
Open
GH-145914: Fill newly created tuple with Py_None instead of NULL#145913sergey-miryanov wants to merge 3 commits intopython:mainfrom
sergey-miryanov wants to merge 3 commits intopython:mainfrom
Conversation
sergey-miryanov
changed the title
Member
|
I'm adding a DO-NOT-MERGE until we address the concern of possibly breaking things downstream on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Py_None instead of NULL in PyTuple_New. This ensures that the tuple is well constructed immediately after calling PyTuple_New.