gh-144651: Disable over-aggressive optimization for _GUARD_CODE_VERSION#145923
Open
Fidget-Spinner wants to merge 3 commits intopython:mainfrom
Open
gh-144651: Disable over-aggressive optimization for _GUARD_CODE_VERSION#145923Fidget-Spinner wants to merge 3 commits intopython:mainfrom
Fidget-Spinner wants to merge 3 commits intopython:mainfrom
Conversation
Fidget-Spinner
requested review from
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
Author
|
@markshannon I'm not actually sure this fix is right. It also smells like a possible function version problem in the function object files. Hopefully this helps you/gives you a solid hint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need the first check in the trace, the subsequent checks can be elided.
For now, let's just restore all checks for correctness reasons. We can come up with a smart way to track whether a code object has been checked in the future.
I don't know how to test this, as any assigning of code object on the function invalidates the function version. We'd need some indirect way of setting the code version?