gh-100239: expose sq_repeat helpers for BINARY_OP_EXTEND#148791
Open
NekoAsakura wants to merge 2 commits intopython:mainfrom
Open
gh-100239: expose sq_repeat helpers for BINARY_OP_EXTEND#148791NekoAsakura wants to merge 2 commits intopython:mainfrom
sq_repeat helpers for BINARY_OP_EXTEND#148791NekoAsakura wants to merge 2 commits intopython:mainfrom
Conversation
eendebakpt
approved these changes
May 7, 2026
| int_str_multiply(PyObject *lhs, PyObject *rhs) | ||
| { | ||
| return seq_int_multiply(rhs, lhs, PyUnicode_Type.tp_as_sequence->sq_repeat); | ||
| Py_ssize_t count = PyLong_AsSsize_t(lhs); |
Contributor
There was a problem hiding this comment.
This section is repeated a couple of times, we could use a macro to define the methods (similar to FLOAT_LONG_ACTION). But current form is also fine with me.
Contributor
Author
There was a problem hiding this comment.
Good point. 17 insertions(+), 59 deletions(-).
Documentation build overview
109 files changed ·
|
Contributor
Author
|
@markshannon gentle ping :') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str * intint * strbytes * intint * bytestuple * intint * tuple