Skip to content

gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)"#149514

Merged
hugovk merged 2 commits intopython:mainfrom
hugovk:3.16-revert-fbba343
May 7, 2026
Merged

gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)"#149514
hugovk merged 2 commits intopython:mainfrom
hugovk:3.16-revert-fbba343

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented May 7, 2026

This reverts commit fbba343 and 310fe88.

Was set to automerge 8 months, and three days ago, respectively, but weren't meant to merge right now.

I'd temporarily removed branch protection to be able to merge #149500 which was needed to fix configure.

Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hugo!

@hugovk hugovk merged commit f0daba1 into python:main May 7, 2026
55 checks passed
@hugovk hugovk deleted the 3.16-revert-fbba343 branch May 7, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants