Repository navigation
Fix star import dependencies in mypy daemon - #21673
Merged
Merged
Conversation
Changes weren't propagated reliably when using `from <...> import *`. This could result in false negatives and false positives. Used coding agent assist with small incremental changes.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Kind of similar pull request that needs review when available, #21818 Though looking closer, it matches the "first time contributor LLM pull request" rule so maybe not worth it. The main reason I want to draw attention though is because the issue it attempts to solve is one that impacts me significantly and I was very excited that someone is trying to fix this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes weren't propagated reliably when exporting names using
from <...> import *. This could result in false negatives and false positives.I used coding agent assist with small incremental changes.