Skip to content

psycopg2: fix types of getconn and conn parameter types in pool stubs #15704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
May 8, 2026
+4 −3
Merged

psycopg2: fix types of getconn and conn parameter types in pool stubs #15704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions stubs/psycopg2/psycopg2/pool.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ from _typeshed import ConvertibleToInt
from collections.abc import Hashable

import psycopg2
from psycopg2.extensions import connection

class PoolError(psycopg2.Error): ...

Expand All @@ -12,13 +13,13 @@ class AbstractConnectionPool:
def __init__(self, minconn: ConvertibleToInt, maxconn: ConvertibleToInt, *args, **kwargs) -> None: ...
# getconn, putconn and closeall are officially documented as methods of the
# abstract base class, but in reality, they only exist on the children classes
def getconn(self, key: Hashable | None = None): ...
def putconn(self, conn, key: Hashable | None = None, close: bool = False) -> None: ...
def getconn(self, key: Hashable | None = None) -> connection: ...
def putconn(self, conn: connection, key: Hashable | None = None, close: bool = False) -> None: ...
def closeall(self) -> None: ...

class SimpleConnectionPool(AbstractConnectionPool): ...

class ThreadedConnectionPool(AbstractConnectionPool):
# This subclass has a default value for conn which doesn't exist
# in the SimpleConnectionPool class, nor in the documentation
def putconn(self, conn=None, key: Hashable | None = None, close: bool = False) -> None: ...
def putconn(self, conn: connection | None = None, key: Hashable | None = None, close: bool = False) -> None: ...
Loading