protocols_runtime_checkable.py: change a multiline isinstance() call to be single-line#2219
Merged
AlexWaygood merged 1 commit intomainfrom Mar 13, 2026
Merged
protocols_runtime_checkable.py: change a multiline isinstance() call to be single-line#2219AlexWaygood merged 1 commit intomainfrom
protocols_runtime_checkable.py: change a multiline isinstance() call to be single-line#2219AlexWaygood merged 1 commit intomainfrom
Conversation
…all to be single-line
AlexWaygood
added
the
topic: conformance tests
JelleZijlstra
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My draft PR implementing this check in ty would cause us to emit an error on the first line of the
isinstance()call expression, which doesn't align with this test's expectations currently. By moving it all onto one line, all other previously passing type checkers continue to pass this assertion, but ty will too.