Skip to content

Fix XNNPACK Prelu for non-4d tensors#18624

Open
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:export-D98987039
Open

Fix XNNPACK Prelu for non-4d tensors#18624
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:export-D98987039

Conversation

@GregoryComer
Copy link
Copy Markdown
Member

@GregoryComer GregoryComer commented Mar 31, 2026

Summary: Prelu with non-4d tensors is broken on xnnpack. This is because the channels last reshape pass assumes that it must be 4d. Update the pass to leave non-4d tensors unmodified. We still treat all 4d tensors as NHWC, though theoretically you could have a 4d tensor + prelu in a non-CV model, but I'm inclined to just leave this for now. We can add smarter 4d handling later if needed.

Differential Revision: D98987039

Summary: Prelu with non-4d tensors is broken on xnnpack. This is because the channels last reshape pass assumes that it must be 4d. Update the pass to leave non-4d tensors unmodified. We still treat all 4d tensors as NHWC, though theoretically you could have a 4d tensor + prelu in a non-CV model, but I'm inclined to just leave this for now. We can add smarter 4d handling later if motivated.

Differential Revision: D98987039
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 31, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18624

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 1 Awaiting Approval, 2 Unrelated Failures

As of commit 87849e1 with merge base 186eb4b (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 31, 2026

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98987039.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant