drm/bridge: display-connector: detect DP state if cable is plugged on boot#397
Open
YongxingMou wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Open
drm/bridge: display-connector: detect DP state if cable is plugged on boot#397YongxingMou wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
YongxingMou wants to merge 2 commits intoqualcomm-linux:qcom-6.18.yfrom
Conversation
If HPD IRQ is enabled in the display_connector's probe, it can be triggered too early, before the DRM connector is completely setup. Use the enable_hpd / disable_hpd callbacks to control enablement of the HPD IRQ. Fixes: 0c275c3 ("drm/bridge: Add bridge driver for display connectors") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-1-786044cedc17@oss.qualcomm.com/
YongxingMou
force-pushed
the
for-2.0-DPprebot
branch
2 times, most recently
from
aff469d to
c523701
Compare
shashim-quic
requested changes
Mar 31, 2026
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
- qcom-6.18.y-check
Associate your CR with this github PR else orbit check will keep failing
YongxingMou
force-pushed
the
for-2.0-DPprebot
branch
from
c523701 to
9ee3f54
Compare
…r DP If the DisplayPort drivers use display-connector for the HPD detection, the internal HPD state machine might be not active and thus the hardware might be not able to handle cable detection correctly. Instead it will depend on the externall HPD notifications to set the cable state, bypassing the internal HPD state machine (for example this is the case for the msm DP driver). However if the cable has been plugged before the HPD IRQ has been enabled, there will be no HPD event coming. The drivers might fail detection in such a case. Trigger the HPD notification after enabling the HPD IRQ, propagating the cable insertion state. Fixes: 2e2bf3a ("drm/bridge: display-connector: add DP support") Reported-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-2-786044cedc17@oss.qualcomm.com/
YongxingMou
force-pushed
the
for-2.0-DPprebot
branch
from
9ee3f54 to
481191b
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the USB-C AltMode handling and unlike the DP controller handling
the HPD on its own, if the display-connector is being used to handle the
HPD pin, DP controller might not be able to get either the HPD
notification nor detect the cable state if the cable is plugged in
before the system has booted.
Make the display-connector send the HPD notifications during system
startup for DisplayPort connectors.
It's typically not a problem for other types of display connectors since
there is no special procedure to detect if the monitor is actually
plugged in or not.
CRs-Fixed:4455495