Skip to content

chore(utils): make platform.sh POSIX-safe and fix ShellCheck warnings #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnarapar merged 1 commit into from
Apr 8, 2026
+2 −7
Merged

chore(utils): make platform.sh POSIX-safe and fix ShellCheck warnings #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Runner/utils/platform.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,14 @@
# Detect Android userland
ANDROID_PATH=/system/build.prop
if [ -f $ANDROID_PATH ]; then
ANDROID=1
Copy link
Copy Markdown
Contributor

@vnarapar vnarapar Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being used in

qcom-linux-testkit/Runner/utils/basics.sh

Line 220 in 528cc75

if [ "$ANDROID" -eq 1 ]; then

Copy link
Copy Markdown
Contributor

@vnarapar vnarapar Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think platform.sh can be removed along with the recedues in basics.sh if there is no dependency.

Copy link
Copy Markdown
Contributor Author

@smuppand smuppand Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being used in

qcom-linux-testkit/Runner/utils/basics.sh

Line 220 in 528cc75

if [ "$ANDROID" -eq 1 ]; then

I don't see any of the files importing these functions for use.

git grep -nE 'platform\.sh|basic\.sh|pidkiller|SHELL_CMD|ANDROID_PATH' .
Runner/utils/basics.sh:10:. "${TOOLS}/platform.sh"
Runner/utils/platform.sh:7:ANDROID_PATH=/system/build.prop
Runner/utils/platform.sh:8:if [ -f $ANDROID_PATH ]; then
Runner/utils/platform.sh:11:    SHELL_CMD=sh
Runner/utils/platform.sh:15:    SHELL_CMD=bash
Runner/utils/platform.sh:18:function pidkiller()

Copy link
Copy Markdown
Contributor

@vnarapar vnarapar Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove platform.sh ?

Copy link
Copy Markdown
Contributor Author

@smuppand smuppand Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove platform.sh ?

Please review the output. The file below still references platform.sh. What steps can we take to remove it? Let it be there for future reference and usage.

Runner/utils/basics.sh:10:. "${TOOLS}/platform.sh"

# shellcheck disable=SC2209,SC2034
SHELL_CMD=sh
else
ANDROID=0
# shellcheck disable=SC2209,SC2034
SHELL_CMD=bash
fi

function pidkiller()
pidkiller()
{
if [ $ANDROID -eq 0 ]; then
disown $1
fi
kill -9 $1 >/dev/null 2>&1
kill -9 "$1" >/dev/null 2>&1
}
Loading