chore(audio): replace expr with POSIX arithmetic in audio_common.sh#388
Open
smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
Open
chore(audio): replace expr with POSIX arithmetic in audio_common.sh#388smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
smuppand wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
audio_common.sh to address ShellCheck SC2003 without changing the existing flow or behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #329 a small lint-only cleanup in Runner/utils/audio_common.sh.
What is changed:
Why this is needed:
ShellCheck reports SC2003 for the current expr usage. Using POSIX
arithmetic expansion resolves the warning while keeping the same runtime
behavior.
Impact: