fix: resolve cross-package test failures in monorepo#26
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook import: useThrottle → useDebounce in apps/web/src/lib/api.ts - Fix date formatting: use day-first without zero-padding (d/MM/yyyy) in packages/utils - Configure happy-dom test environment for UI component tests - Add aria-label pass-through to Button component for accessibility - Fix stale closure bug in DataTable sort handler using functional setState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useThrottlewas renamed touseDebounceinpackages/utilsbutapps/web/src/lib/api.tsstill imported the old name. Fixed the import and re-export alias.formatDateinpackages/utilswas zero-padding the day (01/03/2024). Fixed to used/MM/yyyyformat for Australian locale (e.g.,1/03/2024).happy-domenvironment configuration tobunfig.tomlforpackages/ui.aria-labelto the rendered<button>element. Fixed by spreading all remaining props.setState(prev => ...)pattern.Verification
All 13 tests pass (
bun test). TypeScript check (npx tsc --noEmit) shows only expectedbun:testmodule resolution warnings from test files.Assumptions
bun:testTypeScript errors are pre-existing and not in scope (they're a known bun limitation with type declarations)