fix: resolve all failing tests and type errors#38
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Import missing badRequest helper in users route handler - Fix User type field name (userName → username) in shared types - Fix auth middleware case-sensitivity bug (method comparison now case-insensitive) - Replace process.env with globalThis.process?.env for Node types compatibility in auth middleware - Implement paginate utility function in shared package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
badRequestimport that caused a ReferenceError at runtimeuserNamefield tousernamein theUsertype to match what the API route handlers and tests expectpaginate()function (was a stub throwing "not implemented") — handles page slicing, out-of-range pages, and empty arraysprocess.envwith a Bun/Node-compatible pattern to eliminate theCannot find name 'process'TypeScript errorVerification
bun test)npx tsc --noEmit— only test files show errors due to missingbun:testtype declarations, which is expected)Assumptions