fix: resolve all test failures and type errors#39
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Implement paginate<T>() utility in shared/utils/pagination.ts - Rename userName → username in shared User type for consistency - Add missing badRequest import in api/routes/users.ts - Fix auth middleware case-sensitivity (post → POST) for public routes - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paginate<T>()inpackages/shared/src/utils/pagination.ts— computes total, totalPages, slices items correctly, handles out-of-range pages and empty arrays.userName→usernamein theUsertype (packages/shared/src/types.ts) to match what the API routes and tests expect.badRequestimport topackages/api/src/routes/users.tsfrom the existing response helpers module.packages/api/src/middleware/auth.ts— public routes listedpostbut Hono providesPOST; normalized to uppercase comparison.bun-typesto tsconfig for properprocessand bun runtime type resolution.All 22 tests pass. Zero type errors from
tsc --noEmit.