fix: implement missing functionality and fix edge cases across utility library#191
Open
stooit wants to merge 1 commit into
Open
fix: implement missing functionality and fix edge cases across utility library#191stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…y library - calculator: throw Error on division by zero instead of returning Infinity - string-utils: fix wordCount to handle multiple spaces; implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: use Math.round for day calculation in formatRelative - validator: allow TLDs longer than 4 chars; allow URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Erroron division by zero instead of returningInfinitywordCountto handle multiple consecutive spaces; implementtruncatewith word-boundary logicremove,update, andsortBymethodsMath.roundfor day calculation informatRelative(fixes off-by-one for 36h → "2 days ago")Testing
All 60 tests pass (
bun test). No test files were modified.Assumptions
Error(not a custom type) since tests usetoThrow()without specifying a messagetruncaterespects word boundaries when possible but falls back to hard truncation if no word boundary fits within the limitsortBy("priority")uses high > medium > low orderingsortBy("createdAt")sorts oldest-first (ascending)