Conversation
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
|
@cderv Yes, I think we need to redo the screenshots. In addition to:
I think we should redo:
These other ones can probably remain since they are in sections that aren't as clearly linked to default template:
|
Ok. Probably a good opportunity to create a script to help us redo screenshots quickly. |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
92e5a81 to
3fd8f09
Compare
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
3fd8f09 to
01ba64f
Compare
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
- Add .include-dark to tools.png, myblog.png, and 4 about-page images (trestles, solana, marquee, broadside) so dark variants render - Replace Twitter references with Bluesky in alt text - Use concise alt text matching manifest descriptions - jolla and navbar-tools already updated in prior commits
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
|
And all screenshot done in dark mode now @cwickham All of them will have an example repo, recorded in the manifest I showed you. PR coming on that. What do you think of screenshot updates? The PR diff should show you the images diff too. |
Thanks @cwickham ! Co-authored-by: Charlotte Wickham <charlotte.wickham@posit.co>
Generated by capture.js from manifest entries: - about-jolla: light + dark variants (1200x650 clip) - navbar-tools: light + dark variants (1440x400 clip with dropdown)
- website-about.qmd: add .include-dark, update alt text twitter → Bluesky - website-blog.qmd: add .include-dark, update alt text twitter → Bluesky - website-navigation.qmd: add .include-dark, update alt text Twitter → Bluesky
# Conflicts: # docs/websites/images/about-jolla-dark.png # docs/websites/images/about-jolla.png
Regenerated with updated myblog example (post thumbnails, blue navbar) and maxHeight cropping. Adds myblog-dark.png.
Two images used `fit-alt` instead of `fig-alt`, which rendered as `data-fit-alt` in the HTML instead of a proper `alt` attribute.
Captured from https://quarto-dev.github.io/quarto-demo/ with GitHub dropdown open, showing sidebar title, tools, search, and navigation. # Conflicts: # docs/websites/images/tools-dark.png # docs/websites/images/tools.png
- Add .include-dark to tools.png, myblog.png, and 4 about-page images (trestles, solana, marquee, broadside) so dark variants render - Replace Twitter references with Bluesky in alt text - Use concise alt text matching manifest descriptions - jolla and navbar-tools already updated in prior commits
Switch from quarto.org URL to local breadcrumbs example with matching sidebar structure (Tutorials > Tutorial Landing). Uses darkly + custom SCSS to make breadcrumb background transparent in dark mode. # Conflicts: # docs/websites/images/nav-breadcrumbs-dark.png # docs/websites/images/nav-breadcrumbs.png
Replace anchored and floating sidebar screenshots with new captures from screenshot tooling. Add dark variants and .include-dark class.
Navbar-only element capture at 1000px viewport from navbar-basic example.
nav-bar-hybrid, nav-bar-hybrid-sidebar, nav-bar-hybrid-dropdown with dark mode variants.
Enables dark mode variants for nav-bar-hybrid, nav-bar-hybrid-sidebar, and nav-bar-hybrid-dropdown screenshots.
The dark variant (nav-breadcrumbs-dark.png) was already in the PR but the .qmd reference was missing the .include-dark class.
0fa3cf7 to
0be9e78
Compare
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1815.quarto.org 🔄 Modified Documents |
cwickham
left a comment
There was a problem hiding this comment.
Screenshots all look great!
This follows switch to bluesky in
We have a PR to move from twitter to bluesky in
This closes quarto-dev/quarto-cli#13204 too
We'll have more work for other support
Question
@cwickham we have several screenshot that will show result with past options:
quarto-web/docs/websites/website-navigation.qmd
Line 112 in 1559c73
Should we redo those screenshot and adapt the alt text too ?