Skip to content

Various node changes#3428

Merged
mabijkerk merged 3 commits intomasterfrom
various-node-changes
Mar 23, 2026
Merged

Various node changes#3428
mabijkerk merged 3 commits intomasterfrom
various-node-changes

Conversation

@mabijkerk
Copy link
Copy Markdown
Member

@mabijkerk mabijkerk commented Mar 20, 2026

Context

This pull request cleans up to outdated node groups.

Implemented changes

  • useful_demand_heat_cold was only used in a retired Sankey, the queries for that Sankey still exist
  • buildings_final_demand_for_space_heating_wood_pellets did not seem to be used anywhere and is not really a 'group' since it only contains one node

Related

  • I have tested these changes
  • I have tagged the relevant people for review

Node group useful_demand_heat_cold was not correctly or consistently applied throughout the graph. It was only used in queries for a retired Sankey
This node group was only applied to one node so not an effective group. It was not used anywhere
Copy link
Copy Markdown
Contributor

@kaskranenburgQ kaskranenburgQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mabijkerk mabijkerk merged commit a296dce into master Mar 23, 2026
1 check passed
@mabijkerk mabijkerk deleted the various-node-changes branch March 23, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants