Accept optional job argument in stopping?#747
Open
thoughtless wants to merge 1 commit into
Open
Conversation
Rails commit 6d1c401dc7 ("Pass job instance to stopping?") changed
ActiveJob::Continuable#checkpoint! to call queue_adapter.stopping?(self),
passing the running job so adapters can decide whether to checkpoint
based on it.
This caused errors such as:
ArgumentError: wrong number of arguments (given 1, expected 0)
The new argument is ignored. Solid Queue still relies solely on the
worker shutdown flag. But the signature is now compatible with both
the new and old Rails calling conventions.
Author
|
As far as I can tell, the failing CI tests are flaky and not caused by this change. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails commit 6d1c401dc7 ("Pass job instance to stopping?") changed
ActiveJob::Continuable#checkpoint!to callqueue_adapter.stopping?(self), passing the running job so adapters can decide whether to checkpoint based on it.This caused errors such as:
The new argument is ignored. Solid Queue still relies solely on the worker shutdown flag. But the signature is now compatible with both the new and old Rails calling conventions.