Add: Desktop Icons Toggle ForK#4161
Conversation
It replicates the behavior of the Windows 'View -> Show desktop icons' option, but without using the context menu. It interacts directly with the desktop's SysListView32 window (just like the native function)."
It replicates the behavior of the Windows 'View -> Show desktop icons' option, but without using the context menu. It interacts directly with the desktop's SysListView32 window (just like the native function)."
|
Please use English for the main mod language. Other languages can be added using localization: |
Language change
|
@m417z Done. I've updated the file language to English so everyone can understand it. |
Implementation of windhawk.exe
|
@m417z After a lot of testing and refactoring, I have successfully removed the dependency on explorer.exe injection and migrated the entire mod to run as a standalone tool in a dedicated windhawk.exe process, exactly as requested. I'm going to sleep now. ZZZZZ |
|
The behavior of this mod appears to be similar to mod(pr) #4146 , though it uses a different shortcut. |
|
Yes, it's similar. We also have "Keyboard Shortcut Actions" configuring a keyboard shortcut, and "Click on empty taskbar space" for taskbar empty space clicks, all can be configured to toggle desktop icons. With all these options, I'm not sure we need another similar mod. @KiivYx what do you think? |
|
@ciizerr @m417z That said, it's your call whether that's a meaningful enough difference to justify a separate mod. If you feel it's too close to what's already available, I completely understand and won't take it personally — just let me know which way you'd prefer, and thanks either way for maintaining all this. |
Change name desktop-icons-toggle-fork.wh.cpp to desktop-icons-toggle.wh.cpp
|
I think the overlap is mainly in the purpose (toggling desktop icons), but the way this mod works and shows the option to the user makes it different enough. Whether it should stay separate or be part of the existing mods is up to the maintainers, but I do appreciate the design choices you’ve added. |
|
Hi there! I'm the author of ZenDesktop (#4146). |
| //////////////////////////////////////////////////////////////////////////////// | ||
| // Windhawk tool mod implementation for mods which don't need to inject to other | ||
| // processes or hook other functions. Context: | ||
| // https://github.com/ramensoftware/windhawk/wiki/Mods-as-tools:-Running-mods-in-a-dedicated-process |
There was a problem hiding this comment.
For the code below - keep it as the exact copy of the code in the wiki:
https://github.com/ramensoftware/windhawk/wiki/Mods-as-tools:-Running-mods-in-a-dedicated-process
Delete CreateToolProcessAsActiveUser, and adjust the rest of the code accordingly.
Changelog
If this pull request updates an existing mod, describe the changes below:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.