Add Redirect Settings to Control Panel mod#4278
Conversation
Submission reviewNote: This review was done by Claude, and then refined manually. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. The approach (hooking 1. The Match the actual command precisely instead of substring-scanning: parse the command line into argv, confirm the executable is Related: when the hook intercepts, it does 2. Unmapped 3. 4. 5. Accuracy of the mapping table / overall effectiveness. The README itself states ~70% success on Win10 and ~5% on Win11, and many of the 200+ entries point at unrelated applets — e.g. Since the PR discloses heavy AI assistance, a few of these read like AI artifacts worth a second look: the Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations about the feature behavior itself.
|
…ettings, trimmed mappings Fix review issues: precise command parsing, msc via mmc, string settings, trimmed mappings to enhance the mod
…ngs, trimmed mappings @m417z All review issues addressed: 1. ✅ CreateProcessW now uses IsControlSystemCommand() with proper argv parsing - "System32" path no longer causes false matches 2. ✅ Unmapped shell::: targets pass through to original instead of opening Control Panel 3. ✅ .msc files launched via mmc.exe 4. ✅ FallbackMode changed to string setting with quoted option keys 5. ✅ Removed inaccurate mappings (gaming family, privacy→easeofaccess, taskbar→notification area, bare control.exe redirects) 6. ✅ Fixed NormalizeUri off-by-one (pos+14) 7. ✅ Replaced magic number (HINSTANCE)42 with SHELL_EXECUTE_SUCCESS constant 8. ✅ Removed redundant @compilerOptions 9. ✅ Added control desktop → Personalization mapping 10. ✅ ZeroMemory on PROCESS_INFORMATION struct Ready for re-review.
|
Hello @m417z, I've edited the code to fix the reported issues (command parsing, shell fallback, .msc launching, string settings, wrong mappings). I hope that the mod is now ready for Windhawk. Have a good day! Note: The fixes were assisted by AI. |
babamohammed2022
left a comment
There was a problem hiding this comment.
Hello! The code has been updated.
|
As the review below says, manual testing is expected. Please do extensive manual testing, and post here how the testing was done. Submission reviewNote: This review was done by Claude, and then refined manually. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. Thanks for the quick turnaround — most of the previous round is addressed: the 1. The {L"shell:::{26ee0668-...}\\3\\::{c555438b-...}", L"__display__"}, // line 316
{L"shell:::{f20df4e5-ea01-41a2-b02a-dcbd92d4696e}", L"__display__"}, // line 344Nothing in 2. Mapping accuracy — the gating concern from last round — is only partly addressed. You trimmed the worst offenders (gaming family,
As noted before, for a mod whose entire purpose is accurate redirection, landing on a generic/unrelated page is worse than not redirecting — please prefer fallback-passthrough for subpages that have no real classic equivalent rather than bucketing them onto a parent CLSID. This also ties back to catalog standing: the README still advertises ~5% effectiveness on Windows 11, which is a hard sell for a merged mod. It's worth being honest with yourself about which mappings you've actually verified open the intended page, and dropping the rest. Since the PR still discloses heavy AI assistance, the coarse category→single-CLSID buckets and the dangling Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations about the feature behavior itself.
|
|
Hello @m417z. Regarding the testing methodology: I've tested on Windows 10 21H2 LTSC by opening each URI manually via Start → Run and the ms-settings: protocol, and verified the correct classic window opened. I personally confirmed: personalization (right-click desktop and from inside the window), mouse/touchpad, keyboard, sound, network, firewall, accounts, date/time, devices, printers, UAC prompts for Device Manager/Computer Management/Optional Features, and FallbackMode 0/1/2. |
Redirect Settings to Control Panel
This mod intercepts modern
ms-settings:URI protocols and forces Windows to open their classic Control Panel equivalents using native Windows components and legacy CLSIDs.Features
Compatibility
Limitations
Changelog
If this pull request updates an existing mod, describe the changes below:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.