Skip to content

[4.x] Fixed email is not valid spam#1072

Open
indykoning wants to merge 29 commits into4.xfrom
bugfix/email-is-not-valid
Open

[4.x] Fixed email is not valid spam#1072
indykoning wants to merge 29 commits into4.xfrom
bugfix/email-is-not-valid

Conversation

@indykoning
Copy link
Copy Markdown
Member

@indykoning indykoning commented Nov 13, 2025

Due to the v-model not being lazy debouncePromise is triggered on every character typed.
Which is not a problem for isEmailAvailable with the debounce. However handleGuest attempts to set the email on the cart, where validation is done wether the e-mail address is valid.

This means for every time an email is checked for availability it is also getting blocked by the setGuestEmailOnCart graphql call.

We do not want the v-model being lazy since the CheckoutLogin won't know the entered email until the field gets unfocussed.

see: #1258

Jade-GG
Jade-GG previously approved these changes Nov 14, 2025
@royduin
Copy link
Copy Markdown
Member

royduin commented Nov 14, 2025

Tests are failing? And master is v5 now, so we also need this on 4.x?

@indykoning
Copy link
Copy Markdown
Member Author

Yes, we do want this on V4. I'll update it

@indykoning indykoning changed the base branch from master to 4.x November 17, 2025 14:48
@indykoning indykoning dismissed Jade-GG’s stale review November 17, 2025 14:48

The base branch was changed.

@royduin
Copy link
Copy Markdown
Member

royduin commented Dec 12, 2025

Please double check this one, also for v5 on master

@indykoning
Copy link
Copy Markdown
Member Author

Ref: RAP-1815

@indykoning indykoning changed the title Fixed email is not valid spam [4.x] Fixed email is not valid spam Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants