[5.x] Add roundCurrency helper to round correctly for any currency#1250
Open
[5.x] Add roundCurrency helper to round correctly for any currency#1250
Conversation
indykoning
approved these changes
Apr 7, 2026
Comment on lines
+35
to
+39
| const formatter = new Intl.NumberFormat([(config.locale ?? 'default').replace('_', '-'), 'default'], { | ||
| style: 'currency', | ||
| currency: config.currency ?? 'eur', | ||
| }) | ||
| const digits = formatter.resolvedOptions().maximumFractionDigits |
Member
There was a problem hiding this comment.
Perhaps we could save this in a variable to reduce the amount of numberformatter objects instantiated for each roundCurrency call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: none
The
sumPricesfunction relied on the fact that most currencies have 2 decimals. This will work, until you run into a currency like Yen (0 decimals) or Dinar (3 decimals)1By using
Intl.NumberFormatand getting themaximumFractionDigitsfrom that, we can round properly. I've made a helper function for this and applied it to thesumPricesfunction.Footnotes
https://en.wikipedia.org/wiki/ISO_4217#List_of_ISO_4217_currency_codes ↩