[5.x] Fixed NaN Price and added some caches to attributes#1251
Open
indykoning wants to merge 1 commit intomasterfrom
Open
[5.x] Fixed NaN Price and added some caches to attributes#1251indykoning wants to merge 1 commit intomasterfrom
indykoning wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running toArray would cause the price to be
nullwhile->pricewould return the correct price.This would result in NaN prices for products that are out of stock.
The code causing this is https://github.com/laravel/framework/blob/f374d48bc97144bf2ed6e76b1fa2743e615ad446/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L249
By default they pass
nullas argument to any mutator added to the$appendsWhich we can fix by getting the value from the underlying store.