Remove unneeded CUDF_EXPORT from some cudf/detail headers#21693
Merged
rapids-bot[bot] merged 26 commits intorapidsai:mainfrom Mar 24, 2026
Merged
Remove unneeded CUDF_EXPORT from some cudf/detail headers#21693rapids-bot[bot] merged 26 commits intorapidsai:mainfrom
rapids-bot[bot] merged 26 commits intorapidsai:mainfrom
Conversation
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
davidwendt
added
3 - Ready for Review
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
bdice
approved these changes
Mar 17, 2026
ttnghia
approved these changes
Mar 23, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
CUDF_EXPORTdecorator from many headers in thecpp/include/cudf/detailfolder.All of these have public interfaces and are not longer called outside of libcudf.
Also fixes the doxygen for some of the detail functions as appropriate.
Checklist