Repository navigation
Add Clean Folders extension - #30721
chomamateusz wants to merge 6 commits into
Conversation
|
Congratulations on your new Raycast extension! 🚀 We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days. Once the PR is approved and merged, the extension will be available on our Store. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
[Medium impact] The PR appears safe to merge. SummaryAdds Clean Folders with two commands:
The latest change removes the outdated Reviews (3) · Last reviewed commit: "📝 Describe Trash behaviour without impl..." · Reviewed by Greptile |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi @chomamateusz 👋
Thanks for your contribution 💪
We already have Folder Cleaner in the Store by @StereoPT. It organizes files in a configured folder and supports cleaning one or all files.
This PR moves all contents to the Trash instead, which is a useful difference, but it still fits the same configurable-folder cleaning workflow. Could you look into adding this as another command in the existing extension? If combining them would be impractical, could you explain why here? 🙂
I’ll convert this PR into a draft after submitting this review. Please press Ready for review when it’s ready and we’ll have a look 😊
Thanks @pernielsentikaer! I looked at Folder Cleaner now — and I still think the two workflows are near-opposites:
Putting "sort my files" and "remove everything" behind one icon and one preference pane seems like a footgun :) Folder Cleaner users configure rules precisely because they want to keep their files. The preference models also don't overlap (per-extension rules vs a flat folder list). If you still prefer consolidation, I can open a PR adding this as a command to Folder Cleaner instead — but I'd argue a destructive-by-design tool deserves its own clearly named listing :) |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Hi @chomamateusz 👋
Thanks for explaining how this differs from Folder Cleaner 💪 You're right that Folder Cleaner only sorts files into subfolders and never deletes anything, so we're happy to keep Clean Folders as its own listing.
I found one more thing while reviewing: the README still says "Clean Folders uses /usr/bin/trash and has no rm path anywhere in its implementation". Since 998ccef switched to Raycast's built-in trash() API, that line isn't accurate anymore, and the PR description says the same. Could you update both? Something like "It only ever moves items to the macOS Trash" keeps the point without naming a binary the extension no longer uses 🙂
I’ll convert this PR into a draft after submitting this review. Please press Ready for review when it’s ready and we’ll have a look 😊
Description
Clean Folders moves the contents of configured folders (by default ~/Downloads and ~/Desktop) to the Trash in one hit. It only ever moves items to the macOS Trash, so they can be restored.
Downloads and Desktop fill up fast - every download and every screenshot lands there, especially with screenshot-heavy workflows. Two commands:
Folders are configurable as a comma-separated list in the extension preferences.
Screencast
Store metadata screenshots (included in
metadata/):Checklist
./node_modules/.bin/ray build -e dist./node_modules/.bin/ray lintassetsfolder are used by the extension itselfREADMEare located outside the metadata folder (the README contains no media assets)