Feature/rdk 60236 searchremoved dynamic

[Abhinavpv28]

No description provided.

[github-actions]

Code Coverage Summary

                               Total:|84.1%   6301|97.3%  1664|    -      0

[Copilot]

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/rrdJsonParser.c:178

• split_issue_type() is not syntactically complete: the function body never closes (missing closing braces) and the readJsonFile() comment/definition begins while still inside the split_issue_type control flow. This will not compile; please rewrite/simplify the function and ensure all opened blocks are closed before readJsonFile() starts.

    if (split) {
        size_t b_len = (size_t)(split - input);
        if (b_len >= base_len) b_len = base_len - 1;
        strncpy(base, input, b_len);
        base[b_len] = '\0';

        // Suffix logic as before
        if (strlen(split) <= RRD_MAX_SUFFIX_LEN) {
            size_t si = 0, di = 0;
            size_t max_copy = suffix_len - 1;
            while (split[si] != '\0' && di < max_copy) {
                const char *p = input;
                const char *split = NULL;
                size_t appnd_len = strlen(APPEND_SUFFIX);
                int found_appnd = 0;

                while ((p = strchr(p, '_')) != NULL) {
                    if (strncmp(p, APPEND_SUFFIX, appnd_len) == 0) {
                        found_appnd = 1;
                        // Don't skip the underscore, just mark that APPEND_SUFFIX is present
                        p += appnd_len;
                        continue;
                    } else {
                        split = p;
                        break;
                    }
                }

                if (split) {
                    size_t b_len = (size_t)(split - input);
                    if (b_len >= base_len) b_len = base_len - 1;
                    strncpy(base, input, b_len);
                    base[b_len] = '\0';

                    // Suffix logic as before
                    if (strlen(split) <= RRD_MAX_SUFFIX_LEN) {
                        size_t si = 0, di = 0;
                        size_t max_copy = suffix_len - 1;
                        while (split[si] != '\0' && di < max_copy) {
                            char ch = split[si];
                            if (isalnum((unsigned char)ch) || ch == '_' || ch == '-') {
                                suffix[di++] = ch;
                            }
                            si++;
                        }
                        suffix[di] = '\0';
                    } else {
                        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Suffix after '%s' exceeds max length (%zu > %d); discarding\n",
                                __FUNCTION__, __LINE__, base, strlen(split), RRD_MAX_SUFFIX_LEN);
                        suffix[0] = '\0';
                    }
                } else {
                    // No split point found
                    // If APPEND_SUFFIX was found, base is the whole input (including _ and APPEND_SUFFIX)
                    strncpy(base, input, base_len - 1);
                    base[base_len - 1] = '\0';
                    suffix[0] = '\0';
                }
 * @brief Reads the JSON file and stores the content in a character array.
 * @param char *jsonfile - The name of the JSON file whose content is to be read.
 * @return char* - A string containing the JSON content, or NULL on failure.
 */
char * readJsonFile(char *jsonfile)

[Copilot]

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/rrdJsonParser.c:31

• RRD_MAX_SUFFIX_LEN is defined as 10, but the docstring below describes the max suffix length (including the leading _) as 9. This inconsistency can cause off-by-one behavior (accepting 10-char suffixes) and makes the boundary unclear. Align the constant with the documented/expected limit (or update the documentation/tests if 10 is intended).

#include <sys/stat.h>
#include <sys/types.h>
#include <ctype.h>
#define RRD_MAX_SUFFIX_LEN  10

/*
 * @function removeSpecialChar
 * @brief Removes special characters ('\r' and '\n') from the device properties parameter string.

[github-actions]

Code Coverage Summary

                               Total:|84.1%   6299|97.3%  1664|    -      0

[Copilot]

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/rrdJsonParser.c:31

• RRD_MAX_SUFFIX_LEN is defined as 10, but the function comment (and tests) describe a max suffix length of 9 characters (including the leading '_'). This makes the length validation ambiguous/off-by-one. Align the macro value, comment, and comparisons so the enforced maximum matches the intended contract.

#include <ctype.h>
#define RRD_MAX_SUFFIX_LEN  10

/*
 * @function removeSpecialChar
 * @brief Removes special characters ('\r' and '\n') from the device properties parameter string.

[github-actions]

Code Coverage Summary

                               Total:|84.1%   6300|97.3%  1664|    -      0

[Copilot]

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/rrdJsonParser.c:31

• RRD_MAX_SUFFIX_LEN is defined as 10 but the function documentation/logging describes the maximum allowed suffix length as 9 (including the leading '_'), and unit tests in this PR assert 9 as the upper bound. Please align the constant + documentation/tests (e.g., change the define to 9, or update docs/tests if 10 is intended) so the length gate is unambiguous.

#define RRD_MAX_SUFFIX_LEN  10

/*
 * @function removeSpecialChar
 * @brief Removes special characters ('\r' and '\n') from the device properties parameter string.

[Abhinavpv28]

@copilot

do we need both
void split_issue_type(const char *input, char *base, size_t base_len, char *suffix, size_t suffix_len)
and
static int issueTypeSplitter(char *input_str, const char delimeter, char ***args) ?

[Copilot]

@copilot

do we need both
...

Yes—right now both are needed because they do different jobs: issueTypeSplitter() tokenizes the full issue-type list by comma, and split_issue_type() handles per-token base/suffix parsing, suffix-length validation, and sanitization. If we want, we can later refactor into a single helper, but with current flow keeping both is correct. No UI changes here, so screenshot is not applicable.

[Abhinavpv28]

@copilot can we make issueTypeSplitter() and split_issue_type() to a single function?
is the approach good or bad?

[Copilot]

@copilot can we make issueTypeSplitter() and split_issue_type() to a single function?
is the approach good or bad?

Yes, we can combine them, but for the current code it’s a weaker approach. Keeping them separate is better right now: one function handles list tokenization, and the other handles per-token base/suffix validation/sanitization. Merging would mix two responsibilities and increase regression risk unless we redesign as a single well-scoped parser with full test updates. No UI change, so screenshot is not applicable.