Lock touch direction to avoid change on scroll#580
Open
naikipl wants to merge 3 commits intoreact-component:masterfrom
Open
Lock touch direction to avoid change on scroll#580naikipl wants to merge 3 commits intoreact-component:masterfrom
naikipl wants to merge 3 commits intoreact-component:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
========================================
+ Coverage 95.18% 96% +0.81%
========================================
Files 2 2
Lines 83 100 +17
Branches 25 31 +6
========================================
+ Hits 79 96 +17
Misses 4 4
Continue to review full report at Codecov.
|
Member
|
Rebase please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308
The
onStarttrigger is moved fromonTouchStarttoonTouchMovebecause we need to act on drag direction. The goal being: If the first touch move is in the correct slider direction, triggeronStart; Otherwise, ignore further dragging.Added
onTouchEndfor cleanup.As a result, the following user actions will no longer move a slider: