Repository navigation
Classify legacy bridge JNI headers as private (#58811) - #58811
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122764164. |
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 5, 2026 06:34
24db5a1 to
86ce6be
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 5, 2026 08:12
86ce6be to
ba174cb
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 5, 2026 08:15
ba174cb to
761c396
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 08:32
761c396 to
0bdc602
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 08:34
0bdc602 to
d6f9b87
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 08:39
d6f9b87 to
1f83b3e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 09:57
1f83b3e to
db0e68a
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 09:58
db0e68a to
33b56ee
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 7, 2026 10:03
33b56ee to
7edf1c6
Compare
cortinico
approved these changes
Oct 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 8, 2026 08:25
7edf1c6 to
7f041a0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 8, 2026 08:28
7f041a0 to
b8adbe7
Compare
Summary: Pull Request resolved: react#58811 Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122764164
j-piasecki
force-pushed
the
export-D122764164
branch
from
October 8, 2026 08:33
b8adbe7 to
80cd1ee
Compare
|
This pull request has been merged in 99b2066. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
JavaModuleWrapper.h,JavaScriptExecutorHolder.h,JniJSModulesUnbundle.h,MethodInvoker.handModuleRegistryBuilder.hfrom thereactnativejnitarget as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose privatecxxreacttypes. Consumers that opt intoRN_STRICT_APInow get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour.The remaining headers of
reactnativejniare not classified yet.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D122764164