Repository navigation
Log tier boundary breaks in the C++ API snapshot generator (#58835) - #58835
Closed
j-piasecki wants to merge 2 commits into
Closed
j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D123001749
branch
2 times, most recently
from
October 5, 2026 07:11
1da2e37 to
cc2c8b4
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123001749. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 08:32
cc2c8b4 to
7083925
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 08:34
7083925 to
2ad0f58
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 08:38
2ad0f58 to
ae8a21e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 09:57
ae8a21e to
dc3aea4
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 09:59
dc3aea4 to
547c478
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 7, 2026 10:03
547c478 to
97ef760
Compare
Summary: Classifies `JavaModuleWrapper.h`, `JavaScriptExecutorHolder.h`, `JniJSModulesUnbundle.h`, `MethodInvoker.h` and `ModuleRegistryBuilder.h` from the `reactnativejni` target as "private" under the three-tier C++ stable API visibility model. They exist only to wire the legacy bridge and expose private `cxxreact` types. Consumers that opt into `RN_STRICT_API` now get an error if they include them directly; without that flag the guards are inert, so no existing build changes behaviour. The remaining headers of `reactnativejni` are not classified yet. Changelog: [Internal] Differential Revision: D122764164
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 8, 2026 08:26
97ef760 to
64d6b69
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123001749
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 8, 2026 08:28
64d6b69 to
5cc857e
Compare
Summary: Pull Request resolved: react#58835 Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new `--log-boundary-breaks` flag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123001749
j-piasecki
force-pushed
the
export-D123001749
branch
from
October 8, 2026 08:34
5cc857e to
343d766
Compare
|
This pull request has been merged in 5194f9c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a header tier classifier to the C++ API snapshot generator. A header's tier comes from the stable API guard it includes; headers without one are unclassified. With the new
--log-boundary-breaksflag, the generator logs every public header that reaches a frameworks or private header, and every frameworks header that reaches a private one, with the include chain. Snapshot output is unchanged.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D123001749