Repository navigation
Use umbrella includes in Android app-facing C++ (#58843) - #58843
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123376722. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 5, 2026 11:24
81b9947 to
05782db
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 5, 2026 11:28
05782db to
6946d0e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 7, 2026 07:55
6946d0e to
3d16a52
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 7, 2026 07:59
3d16a52 to
791d93b
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
pushed a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule`, `fabric`, `jni` and `mapbuffer` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`, `<React/NativeModuleCore.h>`, `<React/RendererCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 7, 2026 10:16
791d93b to
3587868
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 7, 2026 10:33
3587868 to
02481ae
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Reviewed By: cipolleschi Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 9, 2026 07:49
02481ae to
2752ef4
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Reviewed By: cipolleschi Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 9, 2026 07:49
2752ef4 to
167fd44
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Reviewed By: cipolleschi Differential Revision: D123376722
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Reviewed By: cipolleschi Differential Revision: D123376722
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Pull Request resolved: react#58843 App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under `RN_STRICT_API`. The default app `OnLoad.cpp` (and RN-Tester's), the generated `autolinking.h`, and the prefab-exported JNI headers in the `newarchdefaults`, `turbomodule` and `jni` packages now include React Native through module umbrellas (`<React/CallInvoker.h>`, `<React/ComponentRegistry.h>`, `<React/NativeModuleCore.h>`, `<React/RuntimeExecutor.h>`). `FabricMountingManager.h` also drops an unused include of `react/renderer/uimanager/primitives.h`. The `fabric`, `mapbuffer` and `DefaultComponentsRegistry.h` headers are handled in the parent diff. No behaviour change without `RN_STRICT_API`. Changelog: [Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header Differential Revision: D123376722
j-piasecki
force-pushed
the
export-D123376722
branch
from
October 9, 2026 07:54
167fd44 to
cb44866
Compare
|
This pull request has been merged in 738e793. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
App-facing C++ on Android included guarded ReactCommon headers directly, which is a hard error in app code under
RN_STRICT_API. The default appOnLoad.cpp(and RN-Tester's), the generatedautolinking.h, and the prefab-exported JNI headers in thenewarchdefaults,turbomoduleandjnipackages now include React Native through module umbrellas (<React/CallInvoker.h>,<React/ComponentRegistry.h>,<React/NativeModuleCore.h>,<React/RuntimeExecutor.h>).FabricMountingManager.halso drops an unused include ofreact/renderer/uimanager/primitives.h. Thefabric,mapbufferandDefaultComponentsRegistry.hheaders are handled in the parent diff. No behaviour change withoutRN_STRICT_API.Changelog:
[Android][Changed] - Include React Native through module umbrella headers in app-facing JNI headers and the generated autolinking header
Reviewed By: cipolleschi
Differential Revision: D123376722