Skip to content

Retier react/renderer/uimanager headers (#58846) #58846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
+5 −43
Closed

Retier react/renderer/uimanager headers (#58846) #58846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/uimanager/AppRegistryBinding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/RendererCore.h>

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/uimanager/LayoutEventEmitter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/uimanager/UIManagerCommitHook.h>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/SurfaceRegistryBinding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#warning "The SurfaceRegistryBinding.h header has been renamed to AppRegistryBinding.h"

#include <react/renderer/uimanager/AppRegistryBinding.h>
3 changes: 1 addition & 2 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerViewTransitionDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <React/Graphics.h>
#include <React/RendererCore.h>

#include <functional>
#include <memory>
#include <optional>
#include <string>

#include <react/renderer/graphics/Float.h>

namespace facebook::react {

class UIManagerViewTransitionDelegate {
Expand Down
13 changes: 0 additions & 13 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,13 +1326,6 @@ class facebook::react::AnimationChoreographer {
public void setAnimationBackend(std::weak_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
}

class facebook::react::AppRegistryBinding {
public AppRegistryBinding() = delete;
public static void setSurfaceProps(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void startSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void stopSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId);
}

class facebook::react::AsyncArrayBuffer {
public AsyncArrayBuffer(const facebook::react::AsyncArrayBuffer&) = delete;
public AsyncArrayBuffer(facebook::react::AsyncArrayBuffer&&) noexcept = default;
Expand Down Expand Up @@ -2600,12 +2593,6 @@ class facebook::react::LayoutAnimationStatusDelegate {
class facebook::react::LayoutConformanceShadowNode : public facebook::react::ConcreteShadowNode<facebook::react::LayoutConformanceShadowNodeComponentName, facebook::react::YogaLayoutableShadowNode, facebook::react::LayoutConformanceProps> {
}

class facebook::react::LayoutEventEmitter : public facebook::react::UIManagerCommitHook {
public virtual void commitHookWasRegistered(const facebook::react::UIManager&) noexcept override;
public virtual void commitHookWasUnregistered(const facebook::react::UIManager&) noexcept override;
public virtual void shadowTreeDidCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& rootShadowNode, const std::vector<const facebook::react::LayoutableShadowNode*>& affectedLayoutableNodes) noexcept override;
}

class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode {
public LayoutableShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public LayoutableShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
Expand Down
13 changes: 0 additions & 13 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3921,13 +3921,6 @@ class facebook::react::AnimationChoreographer {
public void setAnimationBackend(std::weak_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
}

class facebook::react::AppRegistryBinding {
public AppRegistryBinding() = delete;
public static void setSurfaceProps(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void startSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void stopSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId);
}

class facebook::react::AppleEventBeat : public facebook::react::EventBeat, public facebook::react::RunLoopObserver::Delegate {
public AppleEventBeat(const facebook::react::AppleEventBeat&) = delete;
public AppleEventBeat(facebook::react::AppleEventBeat&&) = delete;
Expand Down Expand Up @@ -4836,12 +4829,6 @@ class facebook::react::LayoutAnimationStatusDelegate {
class facebook::react::LayoutConformanceShadowNode : public facebook::react::ConcreteShadowNode<facebook::react::LayoutConformanceShadowNodeComponentName, facebook::react::YogaLayoutableShadowNode, facebook::react::LayoutConformanceProps> {
}

class facebook::react::LayoutEventEmitter : public facebook::react::UIManagerCommitHook {
public virtual void commitHookWasRegistered(const facebook::react::UIManager&) noexcept override;
public virtual void commitHookWasUnregistered(const facebook::react::UIManager&) noexcept override;
public virtual void shadowTreeDidCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& rootShadowNode, const std::vector<const facebook::react::LayoutableShadowNode*>& affectedLayoutableNodes) noexcept override;
}

class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode {
public LayoutableShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public LayoutableShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
Expand Down
13 changes: 0 additions & 13 deletions scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,13 +663,6 @@ class facebook::react::AnimationChoreographer {
public void setAnimationBackend(std::weak_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
}

class facebook::react::AppRegistryBinding {
public AppRegistryBinding() = delete;
public static void setSurfaceProps(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void startSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& initialProps, facebook::react::DisplayMode displayMode);
public static void stopSurface(facebook::jsi::Runtime& runtime, facebook::react::SurfaceId surfaceId);
}

class facebook::react::AsyncArrayBuffer {
public AsyncArrayBuffer(const facebook::react::AsyncArrayBuffer&) = delete;
public AsyncArrayBuffer(facebook::react::AsyncArrayBuffer&&) noexcept = default;
Expand Down Expand Up @@ -1526,12 +1519,6 @@ class facebook::react::LayoutAnimationStatusDelegate {
class facebook::react::LayoutConformanceShadowNode : public facebook::react::ConcreteShadowNode<facebook::react::LayoutConformanceShadowNodeComponentName, facebook::react::YogaLayoutableShadowNode, facebook::react::LayoutConformanceProps> {
}

class facebook::react::LayoutEventEmitter : public facebook::react::UIManagerCommitHook {
public virtual void commitHookWasRegistered(const facebook::react::UIManager&) noexcept override;
public virtual void commitHookWasUnregistered(const facebook::react::UIManager&) noexcept override;
public virtual void shadowTreeDidCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& rootShadowNode, const std::vector<const facebook::react::LayoutableShadowNode*>& affectedLayoutableNodes) noexcept override;
}

class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode {
public LayoutableShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public LayoutableShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits);
Expand Down
Loading