Repository navigation
Retier react/renderer/textlayoutmanager headers (#58851) - #58851
Closed
j-piasecki wants to merge 2 commits into
Closed
j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123394863. |
meta-codesync
Bot
changed the title
react/renderer/textlayoutmanager headersreact/renderer/textlayoutmanager headers (#58851)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Make `TextMeasurementRounding.h` private; it is only used by the iOS text layout manager and its tests. The Windows `TextLayoutManager.h` and `TextLayoutUtil.h` now reach `LayoutConstraints.h` and `ContextContainer.h` through the `<React/RendererCore.h>` and `<React/Utils.h>` umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123394863
j-piasecki
force-pushed
the
export-D123394863
branch
from
October 5, 2026 11:00
ee79654 to
cd53408
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 5, 2026
Summary: Make `TextMeasurementRounding.h` private; it is only used by the iOS text layout manager and its tests. The Windows `TextLayoutManager.h` and `TextLayoutUtil.h` now reach `LayoutConstraints.h` and `ContextContainer.h` through the `<React/RendererCore.h>` and `<React/Utils.h>` umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123394863
j-piasecki
force-pushed
the
export-D123394863
branch
from
October 5, 2026 11:20
cd53408 to
3d0e698
Compare
Summary: Make `AppRegistryBinding.h`, `LayoutEventEmitter.h` and the deprecated `SurfaceRegistryBinding.h` private; they are only used inside React Native. `UIManagerViewTransitionDelegate.h` now reaches `Float.h` through the `<React/Graphics.h>` umbrella instead of including it directly, since `Float.h` is public and its guard rejects direct includes from for-frameworks headers. Changelog: [Internal] Differential Revision: D123391983
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Make `TextMeasurementRounding.h` private; it is only used by the iOS text layout manager and its tests. The Windows `TextLayoutManager.h` and `TextLayoutUtil.h` now reach `LayoutConstraints.h` and `ContextContainer.h` through the `<React/RendererCore.h>` and `<React/Utils.h>` umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123394863
j-piasecki
force-pushed
the
export-D123394863
branch
from
October 9, 2026 08:03
3d0e698 to
b079013
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Make `TextMeasurementRounding.h` private; it is only used by the iOS text layout manager and its tests. The Windows `TextLayoutManager.h` and `TextLayoutUtil.h` now reach `LayoutConstraints.h` and `ContextContainer.h` through the `<React/RendererCore.h>` and `<React/Utils.h>` umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123394863
j-piasecki
force-pushed
the
export-D123394863
branch
from
October 9, 2026 08:04
b079013 to
80cf8f1
Compare
Summary: Pull Request resolved: react#58851 Make `TextMeasurementRounding.h` private; it is only used by the iOS text layout manager and its tests. The Windows `TextLayoutManager.h` and `TextLayoutUtil.h` now reach `LayoutConstraints.h` and `ContextContainer.h` through the `<React/RendererCore.h>` and `<React/Utils.h>` umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123394863
j-piasecki
force-pushed
the
export-D123394863
branch
from
October 9, 2026 08:07
80cf8f1 to
d62ca6f
Compare
|
This pull request has been merged in 29953c1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make
TextMeasurementRounding.hprivate; it is only used by the iOS text layout manager and its tests. The WindowsTextLayoutManager.handTextLayoutUtil.hnow reachLayoutConstraints.handContextContainer.hthrough the<React/RendererCore.h>and<React/Utils.h>umbrellas, matching the other platform variants, since both headers are public and reject direct includes from for-frameworks headers.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D123394863