Skip to content

Classify cxxreact/JSBundleType.h as for-frameworks - #58860

Closed
coado wants to merge 1 commit into
react:mainfrom
coado:export-D123395575
Closed

coado wants to merge 1 commit into
react:mainfrom
coado:export-D123395575

Conversation

@coado

@coado coado commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary:
JSBundleType.h exposes bundle-format detection internals (BundleHeader, ScriptTag, parseTypeFromHeader, isHermesBytecodeBundle). Within React Native it is only used by the bundle loaders, but out-of-tree platforms read BundleHeader directly, so it is classified as "for frameworks" rather than private.

Changelog: [Internal]

Differential Revision: D123395575

Summary:
`JSBundleType.h` exposes bundle-format detection internals (`BundleHeader`, `ScriptTag`, `parseTypeFromHeader`, `isHermesBytecodeBundle`). Within React Native it is only used by the bundle loaders, but out-of-tree platforms read `BundleHeader` directly, so it is classified as "for frameworks" rather than private.

Changelog: [Internal]

Differential Revision: D123395575
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Oct 5, 2026
@meta-codesync

meta-codesync Bot commented Oct 5, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123395575.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 8aafd80 Oct 8, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 8, 2026
@meta-codesync

meta-codesync Bot commented Oct 8, 2026

Copy link
Copy Markdown

This pull request has been merged in 8aafd80.

@facebook-github-tools

Copy link
Copy Markdown

This pull request has been reverted by 4394c07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants