Skip to content

Generate initialHidden as an optional prop for VirtualView (#58864) #58864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartlomiejbloniarz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generate initialHidden as an optional prop for VirtualView (#58864) #58864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/Libraries/Utilities/codegenNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ type NativeComponentOptions = Readonly<{
paperComponentName?: string,
paperComponentNameDeprecated?: string,
excludedPlatforms?: ReadonlyArray<'iOS' | 'android'>,
generateOptionalProperties?: boolean,
generateOptionalObjectProperties?: boolean,
}>;

// Note that this alias is not re-exported from the `react-native` root,
Expand Down
2 changes: 1 addition & 1 deletion ...ct-native/React/Fabric/Mounting/ComponentViews/VirtualView/RCTVirtualViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
const auto &newViewProps = static_cast<const VirtualViewProps &>(*props);

if (!_mode.has_value()) {
_mode = newViewProps.initialHidden ? RCTVirtualViewModeHidden : RCTVirtualViewModeVisible;
_mode = newViewProps.initialHidden.value_or(false) ? RCTVirtualViewModeHidden : RCTVirtualViewModeVisible;
}

switch (newViewProps.renderState) {
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5152,7 +5152,7 @@ public class com/facebook/react/viewmanagers/VirtualViewManagerDelegate : com/fa
}

public abstract interface class com/facebook/react/viewmanagers/VirtualViewManagerInterface : com/facebook/react/uimanager/ViewManagerWithGeneratedInterface {
public abstract fun setInitialHidden (Landroid/view/View;Z)V
public abstract fun setInitialHidden (Landroid/view/View;Ljava/lang/Boolean;)V
public abstract fun setRemoveClippedSubviews (Landroid/view/View;Z)V
public abstract fun setRenderState (Landroid/view/View;I)V
}
Expand Down Expand Up @@ -6580,8 +6580,8 @@ public final class com/facebook/react/views/virtual/view/ReactVirtualViewManager
public synthetic fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Landroid/view/View;
public fun getName ()Ljava/lang/String;
public synthetic fun prepareToRecycleView (Lcom/facebook/react/uimanager/ThemedReactContext;Landroid/view/View;)Landroid/view/View;
public synthetic fun setInitialHidden (Landroid/view/View;Z)V
public fun setInitialHidden (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Z)V
public synthetic fun setInitialHidden (Landroid/view/View;Ljava/lang/Boolean;)V
public fun setInitialHidden (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Ljava/lang/Boolean;)V
public synthetic fun setNativeId (Landroid/view/View;Ljava/lang/String;)V
public fun setNativeId (Lcom/facebook/react/views/virtual/view/ReactVirtualView;Ljava/lang/String;)V
public synthetic fun setRemoveClippedSubviews (Landroid/view/View;Z)V
Expand Down
4 changes: 2 additions & 2 deletions ...actAndroid/src/main/java/com/facebook/react/views/virtual/view/ReactVirtualViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public class ReactVirtualViewManager :
ReactVirtualView(reactContext)

@ReactProp(name = "initialHidden")
override fun setInitialHidden(view: ReactVirtualView, value: Boolean) {
override fun setInitialHidden(view: ReactVirtualView, value: Boolean?) {
if (view.mode == null) {
view.mode = if (value) VirtualViewMode.Hidden else VirtualViewMode.Visible
view.mode = if (value == true) VirtualViewMode.Hidden else VirtualViewMode.Visible
}
}

Expand Down
6 changes: 4 additions & 2 deletions packages/react-native/ReactNativeApi.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<6d379de092b8bad36a420658bbc25a6d>>
* @generated SignedSource<<c7bfb58714c5cd50a054ec7a0090b3f8>>
*
* This file was generated by scripts/js-api/build-types/index.js.
*/
Expand Down Expand Up @@ -3072,6 +3072,8 @@ declare type NativeCommandsOptions<T = string> = {
}
declare type NativeComponentOptions = {
readonly excludedPlatforms?: ReadonlyArray<"android" | "iOS">
readonly generateOptionalObjectProperties?: boolean
readonly generateOptionalProperties?: boolean
readonly interfaceOnly?: boolean
readonly paperComponentName?: string
readonly paperComponentNameDeprecated?: string
Expand Down Expand Up @@ -6055,7 +6057,7 @@ export {
VirtualizedSectionListProps, // 8373f27c
WrapperComponentProvider, // 9b4247f6
codegenNativeCommands, // 322f3f4e
codegenNativeComponent, // e8334853
codegenNativeComponent, // 3da62daa
findNodeHandle, // 93f80214
processColor, // 6e877698
registerCallableModule, // 839c8cfe
Expand Down
4 changes: 3 additions & 1 deletion packages/react-native/src/private/components/virtualview/VirtualViewNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type {
DirectEventHandler,
Double,
Int32,
WithDefault,
} from '../../../../Libraries/Types/CodegenTypes';
import type {HostComponent} from '../../types/HostComponent';

Expand Down Expand Up @@ -65,7 +66,7 @@ type VirtualViewNativeProps = Readonly<{
/**
* Whether the initial mode should be `Hidden`.
*/
initialHidden?: boolean,
initialHidden?: WithDefault<boolean, null>,

/**
* This was needed to get VirtualViewManagerDelegate to set this property.
Expand Down Expand Up @@ -93,4 +94,5 @@ type VirtualViewNativeProps = Readonly<{

export default codegenNativeComponent<VirtualViewNativeProps>('VirtualView', {
interfaceOnly: true,
generateOptionalProperties: true,
}) as HostComponent<VirtualViewNativeProps>;
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2575,9 +2575,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4415,9 +4415,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,9 +2568,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,9 +2568,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override;
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4805,9 +4805,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
}

class facebook::react::YogaLayoutableShadowNode : public facebook::react::LayoutableShadowNode {
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6608,9 +6608,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
}

class facebook::react::YogaLayoutableShadowNode : public facebook::react::LayoutableShadowNode {
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4790,9 +4790,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
}

class facebook::react::YogaLayoutableShadowNode : public facebook::react::LayoutableShadowNode {
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4798,9 +4798,9 @@ struct facebook::react::VirtualViewEventEmitter::OnModeChangeThresholdRect {
class facebook::react::VirtualViewProps : public facebook::react::HostPlatformViewProps {
public VirtualViewProps() = default;
public VirtualViewProps(const facebook::react::PropsParserContext& context, const facebook::react::VirtualViewProps& sourceProps, const facebook::react::RawProps& rawProps);
public bool initialHidden;
public bool removeClippedSubviews;
public int renderState;
public std::optional<bool> initialHidden;
}

class facebook::react::YogaLayoutableShadowNode : public facebook::react::LayoutableShadowNode {
Expand Down
Loading