Repository navigation
Reach react/renderer/graphics through its umbrella (#58881) - #58881
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123603276. |
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D123603276
branch
from
October 9, 2026 08:28
e17ddd5 to
1fe4667
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Headers outside `react/renderer/graphics` that are "for frameworks", or exported without a guard, included fine-grained graphics headers. Under `RN_STRICT_API` those hit the graphics public guard, which `RN_ALLOW_FRAMEWORKS` does not suppress, so they now include `<React/Graphics.h>` instead. The guards are inert without that flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123603276
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 9, 2026
Summary: Headers outside `react/renderer/graphics` that are "for frameworks", or exported without a guard, included fine-grained graphics headers. Under `RN_STRICT_API` those hit the graphics public guard, which `RN_ALLOW_FRAMEWORKS` does not suppress, so they now include `<React/Graphics.h>` instead. The guards are inert without that flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123603276
j-piasecki
force-pushed
the
export-D123603276
branch
from
October 9, 2026 08:28
1fe4667 to
559021b
Compare
Summary: Pull Request resolved: react#58881 Headers outside `react/renderer/graphics` that are "for frameworks", or exported without a guard, included fine-grained graphics headers. Under `RN_STRICT_API` those hit the graphics public guard, which `RN_ALLOW_FRAMEWORKS` does not suppress, so they now include `<React/Graphics.h>` instead. The guards are inert without that flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123603276
j-piasecki
force-pushed
the
export-D123603276
branch
from
October 9, 2026 08:32
559021b to
db41c0c
Compare
|
This pull request has been merged in deef8f4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Headers outside
react/renderer/graphicsthat are "for frameworks", or exported without a guard, included fine-grained graphics headers. UnderRN_STRICT_APIthose hit the graphics public guard, whichRN_ALLOW_FRAMEWORKSdoes not suppress, so they now include<React/Graphics.h>instead. The guards are inert without that flag.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D123603276