Skip to content

Restore RNTester tab safe-area behavior - #58901

Open
cortinico wants to merge 1 commit into
mainfrom
agentcloud/fix-rntester-tab-safe-area
Open

cortinico wants to merge 1 commit into
mainfrom
agentcloud/fix-rntester-tab-safe-area

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:

main commit 8d8b8f3b80b6b8ee5eb3d37c3e70feb422858840 changed RNTesterTabsIOSComponentView to force legacy top and bottom insets whenever the native tab bar is at the bottom. The exact-SHA Test All run then failed its iOS RNTester Maestro coverage:

  • Cloud run: 19/43 flows failed, mostly because scroll-offset-display was no longer found.
  • Focused retries: flatlist-append-maintainvisible failed all 20 attempts across Debug and Release (five attempts in each of two retry rounds) with the same missing element.
  • The parent commit 30e2d93b405ef05b8e3daf47455607673ba9d440 completed Test All successfully, so the regression bisects to 8d8b8f3b80b6b8ee5eb3d37c3e70feb422858840.

This keeps the Fabric plugin import needed by the Buck registration fix while restoring the previous, known-green safe-area calculation.

Changelog:

[INTERNAL] [FIXED] - Restore RNTester example bounds when using native iOS tabs.

Test Plan:

A full iOS Maestro run was not reproduced locally because it requires the RNTester simulator/cloud setup used by GitHub Actions. PR CI is expected to provide the end-to-end confirmation.

Risk / limitations:

Low: this restores the exact safe-area behavior from the green parent while retaining the registration import. The internal Buck-built RNTester may return to its pre-8d8b8f3b content bounds; the component-linking fix itself remains intact.

@cortinico
cortinico requested a review from cipolleschi October 7, 2026 07:58
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Oct 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant