Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
maincommit8d8b8f3b80b6b8ee5eb3d37c3e70feb422858840changedRNTesterTabsIOSComponentViewto force legacy top and bottom insets whenever the native tab bar is at the bottom. The exact-SHATest Allrun then failed its iOS RNTester Maestro coverage:scroll-offset-displaywas no longer found.flatlist-append-maintainvisiblefailed all 20 attempts across Debug and Release (five attempts in each of two retry rounds) with the same missing element.30e2d93b405ef05b8e3daf47455607673ba9d440completedTest Allsuccessfully, so the regression bisects to8d8b8f3b80b6b8ee5eb3d37c3e70feb422858840.This keeps the Fabric plugin import needed by the Buck registration fix while restoring the previous, known-green safe-area calculation.
Changelog:
[INTERNAL] [FIXED] - Restore RNTester example bounds when using native iOS tabs.
Test Plan:
xcrun clang-format --dry-run --Werror packages/rn-tester/RNTesterTabsIOS/ios/RNTesterTabsIOSComponentView.mm— passed with Apple clang-format 21.0.0.git diff --check— passed.30e2d93b405ef05b8e3daf47455607673ba9d440; the only remaining source change is the plugin import from the original Buck-linking fix.A full iOS Maestro run was not reproduced locally because it requires the RNTester simulator/cloud setup used by GitHub Actions. PR CI is expected to provide the end-to-end confirmation.
Risk / limitations:
Low: this restores the exact safe-area behavior from the green parent while retaining the registration import. The internal Buck-built RNTester may return to its pre-
8d8b8f3bcontent bounds; the component-linking fix itself remains intact.