Skip to content

Fix iOS maintainVisibleContentPosition skipping a clipped anchor #58912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mozzius wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix iOS maintainVisibleContentPosition skipping a clipped anchor #58912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,12 +1111,6 @@ - (void)_adjustForMaintainVisibleContentPosition
return;
}

// Abort if the first visible view was deleted during mount (not recycled)
// This prevents MVCP from applying a delta after scrollToOffset(0) during reset/clear
if (_firstVisibleView.superview != _contentView) {
return;
}

std::optional<int> autoscrollThreshold = props.maintainVisibleContentPosition.value().autoscrollToTopThreshold;
BOOL horizontal = _scrollView.contentSize.width > self.frame.size.width;
// TODO: detect and handle/ignore re-ordering
Expand Down
Loading