Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
3 of 4 tasks
facebook-github-tools
Bot
added
the
Shared with Meta
cipolleschi
approved these changes
Oct 7, 2026
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D123878627. |
|
@cipolleschi merged this pull request in ff78e95. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS,
prepareForRecycleresets_removeClippedSubviewstoNObut keeps_props, andupdateProps:oldProps:only set the flag whenremoveClippedSubviewsdiffered from_props. So a recycled view whose previous props also hadremoveClippedSubviewsnever turned clipping back on, and a remountedScrollView/FlatListkept every row attached. This compares against_removeClippedSubviewsitself, and adds a test.Fixes #58914. Repro: https://github.com/mozzius/view-remove-clipped-subviews-recycle-repro
Changelog:
[IOS] [FIXED] - removeClippedSubviews is kept on recycled views
Test Plan:
In the repro (a
ScrollViewwithremoveClippedSubviewsand 100 rows, unmounted and mounted again), the recycled content view keeps all 100/100 rows attached on every remount without this change (7/7, including 3/3 on unmodified 0.87.1), and 7/100 with it (3/3), the same as on first mount. The newRCTViewComponentViewTestscase, run inside the repro app against 0.87.1 built from source, fails without the change and passes with it.🤖 Generated with Claude Code