Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123623731. |
cortinico
approved these changes
Oct 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D123623731
branch
from
October 8, 2026 08:54
de2eee9 to
db1f29f
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 8, 2026
…8917) Summary: Mark three platform-specific `react/renderer/components/scrollview` headers as private: - iOS `RCTComponentViewHelpers.h` (previously untiered): the `RCTScrollViewProtocol` / `RCTScrollViewHandleCommand` helper used only by React Native's own iOS ScrollView component view to dispatch commands. - Android `AndroidHorizontalScrollContentViewComponentDescriptor.h` and `AndroidHorizontalScrollContentViewShadowNode.h` (previously "for frameworks"): the component is registered only by React Native's own Android core components registry, and the shadow node is only included by its descriptor. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123623731
…8917) Summary: Pull Request resolved: react#58917 Mark three platform-specific `react/renderer/components/scrollview` headers as private: - iOS `RCTComponentViewHelpers.h` (previously untiered): the `RCTScrollViewProtocol` / `RCTScrollViewHandleCommand` helper used only by React Native's own iOS ScrollView component view to dispatch commands. - Android `AndroidHorizontalScrollContentViewComponentDescriptor.h` and `AndroidHorizontalScrollContentViewShadowNode.h` (previously "for frameworks"): the component is registered only by React Native's own Android core components registry, and the shadow node is only included by its descriptor. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123623731
coado
force-pushed
the
export-D123623731
branch
from
October 8, 2026 08:58
db1f29f to
4d5b675
Compare
|
This pull request has been merged in 1538234. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mark three platform-specific
react/renderer/components/scrollviewheaders as private:RCTComponentViewHelpers.h(previously untiered): theRCTScrollViewProtocol/RCTScrollViewHandleCommandhelper used only by React Native's own iOS ScrollView component view to dispatch commands.AndroidHorizontalScrollContentViewComponentDescriptor.handAndroidHorizontalScrollContentViewShadowNode.h(previously "for frameworks"): the component is registered only by React Native's own Android core components registry, and the shadow node is only included by its descriptor.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D123623731