Skip to content

Make TextInput descriptors and prop conversion helpers private (#58919) #58919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coado wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −22
Open

Make TextInput descriptors and prop conversion helpers private (#58919) #58919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/components/textinput/baseConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/RendererCore.h>
#include <react/renderer/components/textinput/basePrimitives.h>
Expand Down
2 changes: 1 addition & 1 deletion .../android/react/renderer/components/androidtextinput/AndroidTextInputComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "AndroidTextInputShadowNode.h"
#include "AndroidTextInputState.h"
Expand Down
2 changes: 1 addition & 1 deletion ...tinput/platform/ios/react/renderer/components/iostextinput/TextInputComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/RendererCore.h>
#include <react/renderer/components/iostextinput/TextInputShadowNode.h>
Expand Down
2 changes: 1 addition & 1 deletion ...mponents/textinput/platform/ios/react/renderer/components/iostextinput/propsConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/Debug.h>
#include <React/RendererCore.h>
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,6 @@ folly::dynamic facebook::react::toDynamic(const facebook::react::FilterFunction&
folly::dynamic facebook::react::toDynamic(const facebook::react::ImageSource& imageSource);
folly::dynamic facebook::react::toDynamic(const facebook::react::Point& point);
folly::dynamic facebook::react::toDynamic(const facebook::react::SharedColor& sharedColor);
folly::dynamic facebook::react::toDynamic(const facebook::react::SubmitBehavior& value);
folly::dynamic facebook::react::toDynamic(const std::vector<bool>& arrayValue);
folly::dynamic facebook::react::toDynamic(const std::vector<double>& arrayValue);
folly::dynamic facebook::react::toDynamic(const std::vector<facebook::react::Float>& arrayValue);
Expand Down Expand Up @@ -937,7 +936,6 @@ void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, c
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::LineBreakMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Point& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Size& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::SubmitBehavior& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextAlignmentVertical& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextWidthMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::ValueUnit& result);
Expand Down Expand Up @@ -1159,12 +1157,6 @@ class facebook::react::AndroidSwitchProps : public facebook::react::HostPlatform
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}

class facebook::react::AndroidTextInputComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::AndroidTextInputShadowNode> {
protected virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
public AndroidTextInputComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
public virtual facebook::react::State::Shared createInitialState(const facebook::react::Props::Shared& props, const facebook::react::ShadowNodeFamily::Shared& family) const override;
}

class facebook::react::AndroidTextInputEventEmitter : public facebook::react::BaseViewEventEmitter {
}

Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3570,7 +3570,6 @@ float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
folly::dynamic facebook::react::toDynamic(const facebook::react::SubmitBehavior& value);
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
Expand Down Expand Up @@ -3708,7 +3707,6 @@ void facebook::react::fromRawValue(const facebook::react::PropsParserContext& co
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::ScrollViewKeyboardDismissMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::ScrollViewMaintainVisibleContentPosition& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::ScrollViewSnapToAlignment& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::Selection& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::TextAlignment& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::TextBreakStrategy& result);
Expand Down Expand Up @@ -3740,7 +3738,6 @@ void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, c
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::LineBreakMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Point& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Size& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::SubmitBehavior& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextAlignmentVertical& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextWidthMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::ValueUnit& result);
Expand Down Expand Up @@ -6186,11 +6183,6 @@ class facebook::react::TextAttributes : public facebook::react::DebugStringConve
public void apply(facebook::react::TextAttributes textAttributes);
}

class facebook::react::TextInputComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::TextInputShadowNode> {
protected virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
public TextInputComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
}

class facebook::react::TextInputEventEmitter : public facebook::react::BaseViewEventEmitter {
public void onBlur(const facebook::react::TextInputEventEmitter::Metrics& textInputMetrics) const;
public void onChange(const facebook::react::TextInputEventEmitter::Metrics& textInputMetrics) const;
Expand Down
2 changes: 0 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@ facebook::yoga::FloatOptional facebook::react::yogaOptionalFloatFromFloat(Float
float facebook::react::yogaFloatFromFloat(Float value);
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
folly::dynamic facebook::react::toDynamic(const facebook::react::SubmitBehavior& value);
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
size_t facebook::react::attributedStringFragmentHashDisplayWise(const facebook::react::AttributedString::Fragment& fragment);
Expand Down Expand Up @@ -503,7 +502,6 @@ void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, c
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::LineBreakMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Point& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Size& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::SubmitBehavior& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextAlignmentVertical& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextWidthMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::ValueUnit& result);
Expand Down
Loading