Repository navigation
Update LogBox snapshots for the C++ Image resizeMode default - #58923
Closed
bartlomiejbloniarz wants to merge 1 commit into
Closed
bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
Summary: `Image` `resizeMode` now defaults to `cover` in C++, so Fantom no longer renders `resizeMode="cover"` on `<rn-image>`. The `Image` integration tests were updated for this, but the LogBox UI snapshots still expected the prop, so 6 LogBox Fantom tests fail on main. Changelog: [Internal] Differential Revision: D123876368
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123876368. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Summary: `Image` `resizeMode` now defaults to `cover` in C++, so Fantom no longer renders `resizeMode="cover"` on `<rn-image>`. The `Image` integration tests were updated for this, but the LogBox UI snapshots still expected the prop, so 6 LogBox Fantom tests fail on main. Changelog: [Internal] Reviewed By: rickhanlonii Differential Revision: D123876368
|
This pull request has been merged in 618b844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ImageresizeModenow defaults tocoverin C++, so Fantom no longer rendersresizeMode="cover"on<rn-image>. TheImageintegration tests were updated for this, but the LogBox UI snapshots still expected the prop, so 6 LogBox Fantom tests fail on main.Changelog: [Internal]
Differential Revision: D123876368